Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js

Issue 1922073002: DevTools: polish service worker inspector UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js b/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
index 0d4f2a686e4e5052e8b35f8163007f4aee07fc24..86e6641fdadd6d9a463b5ff1c96fbeb3b9d84ad1 100644
--- a/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
@@ -217,7 +217,7 @@ WebInspector.ResourcesPanel.prototype = {
this.cookieListTreeElement.removeChildren();
this.cacheStorageListTreeElement.removeChildren();
- if (this.visibleView && !(this.visibleView instanceof WebInspector.StorageCategoryView) && !(this.visibleView instanceof WebInspector.ServiceWorkersView))
+ if (this.visibleView && !(this.visibleView instanceof WebInspector.StorageCategoryView))
this.visibleView.detach();
this._storageViewToolbar.removeToolbarItems();
@@ -535,14 +535,6 @@ WebInspector.ResourcesPanel.prototype = {
},
/**
- * @param {!WebInspector.Widget} view
- */
- showServiceWorkersView: function(view)
- {
- this._innerShowView(view);
- },
-
- /**
* @param {!WebInspector.DOMStorage} domStorage
*/
_showDOMStorage: function(domStorage)
@@ -1536,10 +1528,10 @@ WebInspector.ServiceWorkersTreeElement.prototype = {
*/
onselect: function(selectedByUser)
{
- WebInspector.BaseStorageTreeElement.prototype.onselect.call(this, selectedByUser);
- if (!this._view)
- this._view = new WebInspector.ServiceWorkersView();
- this._storagePanel.showServiceWorkersView(this._view);
+ WebInspector.inspectorView.showViewInDrawer("service_workers");
+ var view = new WebInspector.VBox();
+ view.element.createChild("div", "service-worker-info-message").textContent = WebInspector.UIString("Service Worker inspector pane moved into the drawer below");
+ this._storagePanel._innerShowView(view);
return false;
},

Powered by Google App Engine
This is Rietveld 408576698