Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js

Issue 1922073002: DevTools: polish service worker inspector UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebaselined test Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @param {!WebInspector.DeviceModeModel} model 6 * @param {!WebInspector.DeviceModeModel} model
7 * @param {!WebInspector.Setting} showMediaInspectorSetting 7 * @param {!WebInspector.Setting} showMediaInspectorSetting
8 * @param {!WebInspector.Setting} showRulersSetting 8 * @param {!WebInspector.Setting} showRulersSetting
9 * @constructor 9 * @constructor
10 */ 10 */
(...skipping 248 matching lines...) Expand 10 before | Expand all | Expand 10 after
259 { 259 {
260 contextMenu.appendCheckboxItem(title, uaSetting.set.bind(uaSetting, value), uaSetting.get() === value); 260 contextMenu.appendCheckboxItem(title, uaSetting.set.bind(uaSetting, value), uaSetting.get() === value);
261 } 261 }
262 }, 262 },
263 263
264 /** 264 /**
265 * @param {!WebInspector.ContextMenu} contextMenu 265 * @param {!WebInspector.ContextMenu} contextMenu
266 */ 266 */
267 _appendOptionsMenuItems: function(contextMenu) 267 _appendOptionsMenuItems: function(contextMenu)
268 { 268 {
269 contextMenu.appendCheckboxItem(WebInspector.UIString("Show device pixel ratio"), this._toggleDeviceScaleFactor.bind(this), this._showDeviceScaleFactorSe tting.get(), this._model.type() === WebInspector.DeviceModeModel.Type.None); 269 var submenu = contextMenu.appendSubMenuItem(WebInspector.UIString("Show" ));
270 contextMenu.appendCheckboxItem(WebInspector.UIString("Show device type") , this._toggleUserAgentType.bind(this), this._showUserAgentTypeSetting.get(), th is._model.type() === WebInspector.DeviceModeModel.Type.None); 270 submenu.appendCheckboxItem(WebInspector.UIString("Device pixel ratio"), this._toggleDeviceScaleFactor.bind(this), this._showDeviceScaleFactorSetting.get (), this._model.type() === WebInspector.DeviceModeModel.Type.None);
271 contextMenu.appendCheckboxItem(WebInspector.UIString("Show throttling"), this._toggleNetworkConditions.bind(this), this._showNetworkConditionsSetting.ge t(), this._model.type() === WebInspector.DeviceModeModel.Type.None); 271 submenu.appendCheckboxItem(WebInspector.UIString("Device type"), this._t oggleUserAgentType.bind(this), this._showUserAgentTypeSetting.get(), this._model .type() === WebInspector.DeviceModeModel.Type.None);
272 contextMenu.appendCheckboxItem(WebInspector.UIString("Show media queries "), this._toggleMediaInspector.bind(this), this._showMediaInspectorSetting.get() , this._model.type() === WebInspector.DeviceModeModel.Type.None); 272 submenu.appendCheckboxItem(WebInspector.UIString("Network throttling"), this._toggleNetworkConditions.bind(this), this._showNetworkConditionsSetting.get (), this._model.type() === WebInspector.DeviceModeModel.Type.None);
273 contextMenu.appendCheckboxItem(WebInspector.UIString("Show rulers"), thi s._toggleRulers.bind(this), this._showRulersSetting.get(), this._model.type() == = WebInspector.DeviceModeModel.Type.None); 273 submenu.appendCheckboxItem(WebInspector.UIString("Media queries"), this. _toggleMediaInspector.bind(this), this._showMediaInspectorSetting.get(), this._m odel.type() === WebInspector.DeviceModeModel.Type.None);
274 submenu.appendCheckboxItem(WebInspector.UIString("Rulers"), this._toggle Rulers.bind(this), this._showRulersSetting.get(), this._model.type() === WebInsp ector.DeviceModeModel.Type.None);
274 if (Runtime.experiments.isEnabled("deviceFrames")) { 275 if (Runtime.experiments.isEnabled("deviceFrames")) {
275 contextMenu.appendCheckboxItem(WebInspector.UIString("Show device fr ame"), this._toggleDeviceFrames.bind(this), this._deviceOutlineSetting.get() && this._model.outlineImage() !== "", (this._model.type() === WebInspector.DeviceMo deModel.Type.None || this._model.outlineImage() === "")); 276 contextMenu.appendCheckboxItem(WebInspector.UIString("Show device fr ame"), this._toggleDeviceFrames.bind(this), this._deviceOutlineSetting.get() && this._model.outlineImage() !== "", (this._model.type() === WebInspector.DeviceMo deModel.Type.None || this._model.outlineImage() === ""));
276 } 277 }
278 contextMenu.appendSeparator();
277 contextMenu.appendItemsAtLocation("deviceModeMenu"); 279 contextMenu.appendItemsAtLocation("deviceModeMenu");
278 contextMenu.appendSeparator(); 280 contextMenu.appendSeparator();
279 contextMenu.appendItem(WebInspector.UIString("Reset to defaults"), this. _reset.bind(this)); 281 contextMenu.appendItem(WebInspector.UIString("Reset to defaults"), this. _reset.bind(this));
280 }, 282 },
281 283
282 _toggleDeviceScaleFactor: function() 284 _toggleDeviceScaleFactor: function()
283 { 285 {
284 this._showDeviceScaleFactorSetting.set(!this._showDeviceScaleFactorSetti ng.get()); 286 this._showDeviceScaleFactorSetting.set(!this._showDeviceScaleFactorSetti ng.get());
285 }, 287 },
286 288
(...skipping 293 matching lines...) Expand 10 before | Expand all | Expand 10 after
580 this._emulateDevice(device); 582 this._emulateDevice(device);
581 return; 583 return;
582 } 584 }
583 } 585 }
584 } 586 }
585 } 587 }
586 588
587 this._model.emulate(WebInspector.DeviceModeModel.Type.Responsive, null, null); 589 this._model.emulate(WebInspector.DeviceModeModel.Type.Responsive, null, null);
588 } 590 }
589 } 591 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698