Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1922073002: DevTools: polish service worker inspector UI (Closed)

Created:
4 years, 8 months ago by pfeldman
Modified:
4 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: polish service worker inspector UI Committed: https://crrev.com/2fd6ac7fbb996bac4968aca3c953ba5b9635fdc6 Cr-Commit-Position: refs/heads/master@{#390118}

Patch Set 1 #

Total comments: 1

Patch Set 2 : polished ui, left in place #

Patch Set 3 : rebaselined test #

Messages

Total messages: 19 (10 generated)
pfeldman
4 years, 8 months ago (2016-04-26 06:06:15 UTC) #2
dgozman
lgtm https://codereview.chromium.org/1922073002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/smallIcon.css File third_party/WebKit/Source/devtools/front_end/ui/smallIcon.css (right): https://codereview.chromium.org/1922073002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/smallIcon.css#newcode12 third_party/WebKit/Source/devtools/front_end/ui/smallIcon.css:12: flex-shrink: 0; I'm worried this could break something ...
4 years, 8 months ago (2016-04-26 23:38:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922073002/20001
4 years, 8 months ago (2016-04-27 00:02:21 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/219318)
4 years, 8 months ago (2016-04-27 01:16:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922073002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922073002/40001
4 years, 8 months ago (2016-04-27 05:23:50 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/128467) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 8 months ago (2016-04-27 05:33:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922073002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922073002/40001
4 years, 7 months ago (2016-04-27 17:33:31 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-04-27 17:48:24 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:11:02 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2fd6ac7fbb996bac4968aca3c953ba5b9635fdc6
Cr-Commit-Position: refs/heads/master@{#390118}

Powered by Google App Engine
This is Rietveld 408576698