Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: third_party/WebKit/LayoutTests/imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-table-fixup-001.xhtml

Issue 1922043004: Import csswg-test@b2daa426addd5ccb8e9ce1c5d800f9d82603f1ec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update W3CImportExpectations and make me owner for css-scoping-1 Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-table-fixup-001.xhtml
diff --git a/third_party/WebKit/LayoutTests/imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-table-fixup-001a.xhtml b/third_party/WebKit/LayoutTests/imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-table-fixup-001.xhtml
similarity index 54%
rename from third_party/WebKit/LayoutTests/imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-table-fixup-001a.xhtml
rename to third_party/WebKit/LayoutTests/imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-table-fixup-001.xhtml
index b87151ad9c6a9348f6ea920f387a382ef3aebb64..8ea82dfcac0b6396eb56bf804b44bdab4db5b4dd 100644
--- a/third_party/WebKit/LayoutTests/imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-table-fixup-001a.xhtml
+++ b/third_party/WebKit/LayoutTests/imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-table-fixup-001.xhtml
@@ -4,14 +4,15 @@
http://creativecommons.org/publicdomain/zero/1.0/
-->
<!--
- Testcase with table parts inside of a flex container, triggering
- table-fixup. We use justify-content:space-between to stick packing
+ Testcase with table parts inside of a flex container, which should *not*
+ trigger table-fixup. We use justify-content:space-between to stick packing
space between flex items, so that we can verify that e.g. a contiguous
- run of <td>s will end up in the same flex item (wrapped in a table).
+ run of <td>s will each be blockified & form its own flex item (instead of
+ being aggregated into a single table & single flex item).
-->
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
- <title>CSS Test: Testing that table cells in a flex container get an anonymous table wrapper that forms the flex item</title>
+ <title>CSS Test: Testing that table cells in a flex container get blockified and each form their own flex item</title>
<link rel="author" title="Daniel Holbert" href="mailto:dholbert@mozilla.com"/>
<link rel="help" href="http://www.w3.org/TR/css-flexbox-1/#flex-items"/>
<link rel="match" href="flexbox-table-fixup-001-ref.xhtml"/>
@@ -23,12 +24,10 @@
justify-content: space-around;
}
- <!-- NOTE: table-fixup pads each td element by 1px on each side. We
- override that for top & bottom, for simplicity. So the td makes us
- generate a box that's 2px wider than its contents. -->
td {
- padding-top: 0px;
- padding-bottom: 0px;
+ /* Remove any default padding for td elements, so we can compare them
+ easily against blocks in the reference case. */
+ padding: 0px;
}
.a {
@@ -48,19 +47,19 @@
</style>
</head>
<body>
- <!-- Just 2 adjacent table cells (they end up in the same table) -->
+ <!-- The adjacent table-parts in each example below should *not* be
+ grouped into the same flex item. -->
+ <!-- 2 adjacent table cells -->
<div class="flexbox"
><td class="a">cell1</td><td class="b">cell2</td></div>
- <!-- Table cell followed by tbody (they end up in the same table) -->
+ <!-- Table cell followed by tbody -->
<div class="flexbox"
><td class="a">cell1</td><tbody class="b">t</tbody></div>
- <!-- Empty table cell (ends up occupying 2px of width), followed by div,
- followed by nonempty table cell. (3 flex items). -->
- <!-- Note: We use "space-between" (instead of "space-around") here because
- it makes the math cleaner. (100px split 2 ways instead of 3 ways.) -->
- <div class="flexbox" style="justify-content: space-between"
- ><td></td><div class="c">div</div><td class="b">cell1</td></div>
+ <!-- Empty table cell (ends up occupying 2px of width), followed by
+ nonempty table cell. -->
+ <div class="flexbox"
+ ><td></td><td class="b">cell1</td></div>
</body>
</html>

Powered by Google App Engine
This is Rietveld 408576698