Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1922043003: Fix crash with --mojo-local-storage (Closed)

Created:
4 years, 8 months ago by Ben Goodger (Google)
Modified:
4 years, 8 months ago
Reviewers:
jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash with --mojo-local-storage null process id was being sent for threads created in the shell process. Use shell process id instead. R=jam@chromium.org BUG= Committed: https://crrev.com/9e0b9dc2123d6eaeb8a073bc57a781bb8de1c5af Cr-Commit-Position: refs/heads/master@{#389841}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M services/shell/runner/host/in_process_native_runner.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Ben Goodger (Google)
4 years, 8 months ago (2016-04-26 17:28:10 UTC) #1
jam
lgtm
4 years, 8 months ago (2016-04-26 17:28:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922043003/1
4 years, 8 months ago (2016-04-26 17:35:29 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 19:13:09 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 19:15:08 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9e0b9dc2123d6eaeb8a073bc57a781bb8de1c5af
Cr-Commit-Position: refs/heads/master@{#389841}

Powered by Google App Engine
This is Rietveld 408576698