Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1922013002: Rename gfx::Display/Screen to display::Display/Screen in message_center (Closed)

Created:
4 years, 8 months ago by oshima
Modified:
4 years, 8 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename gfx::Display/Screen to display::Display/Screen in message_center BUG=597761 Committed: https://crrev.com/4e110b64d13083871da08496d0fbc389c7a76153 Cr-Commit-Position: refs/heads/master@{#389807}

Patch Set 1 : #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -32 lines) Patch
M ui/message_center/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/message_center/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/message_center/message_center.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/message_center/views/desktop_popup_alignment_delegate.h View 5 chunks +13 lines, -9 lines 1 comment Download
M ui/message_center/views/desktop_popup_alignment_delegate.cc View 4 chunks +10 lines, -13 lines 0 comments Download
M ui/message_center/views/message_popup_collection.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M ui/message_center/views/message_popup_collection.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M ui/message_center/views/message_popup_collection_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/message_center/views/popup_alignment_delegate.h View 2 chunks +5 lines, -1 line 0 comments Download
M ui/message_center/views/toast_contents_view.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922013002/20001
4 years, 8 months ago (2016-04-26 01:29:01 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922013002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922013002/40001
4 years, 8 months ago (2016-04-26 02:08:59 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-26 03:16:27 UTC) #7
oshima
4 years, 8 months ago (2016-04-26 06:03:44 UTC) #9
oshima
4 years, 8 months ago (2016-04-26 06:04:07 UTC) #11
oshima
https://codereview.chromium.org/1922013002/diff/40001/ui/message_center/views/desktop_popup_alignment_delegate.h File ui/message_center/views/desktop_popup_alignment_delegate.h (right): https://codereview.chromium.org/1922013002/diff/40001/ui/message_center/views/desktop_popup_alignment_delegate.h#newcode21 ui/message_center/views/desktop_popup_alignment_delegate.h:21: } This is temporary and will be consolidated to ...
4 years, 8 months ago (2016-04-26 06:04:50 UTC) #12
stevenjb
lgtm
4 years, 8 months ago (2016-04-26 15:41:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922013002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922013002/40001
4 years, 8 months ago (2016-04-26 16:43:23 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 8 months ago (2016-04-26 16:48:45 UTC) #17
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 16:50:06 UTC) #19
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4e110b64d13083871da08496d0fbc389c7a76153
Cr-Commit-Position: refs/heads/master@{#389807}

Powered by Google App Engine
This is Rietveld 408576698