Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 1921973006: Revert of Remove CAPS (Closed)

Created:
4 years, 7 months ago by Charlie Reis
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke, sky, scottmg
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove CAPS (patchset #2 id:20001 of https://codereview.chromium.org/1858883004/ ) Reason for revert: Caused a compile error on Win: https://build.chromium.org/p/chromium/builders/Win/builds/42776 ninja: error: '../../chrome/tools/crash_service/main.cc', needed by 'obj/chrome/tools/crash_service/crash_service.main.obj', missing and no known rule to make it Original issue's description: > Remove CAPS > > One less crash_service, which is especially confusing because there's two > crash_service targets and also a content_shell_crash_service.exe. > > TBR=sky > > Committed: https://crrev.com/7e3c4177dd1de27b69109d45ce7f87f0524bc70f > Cr-Commit-Position: refs/heads/master@{#389907} TBR=dpranke@chromium.org,sky@chromium.org,scottmg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/6084075b5b792b3cf779a814b3fc089a07c331bd Cr-Commit-Position: refs/heads/master@{#389916}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+443 lines, -0 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M build/gn_migration.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/tools/crash_service/BUILD.gn View 1 chunk +49 lines, -0 lines 0 comments Download
A chrome/tools/crash_service/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/tools/crash_service/caps/caps.gyp View 1 chunk +56 lines, -0 lines 0 comments Download
A chrome/tools/crash_service/caps/caps.ver View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/tools/crash_service/caps/exit_codes.h View 1 chunk +21 lines, -0 lines 0 comments Download
A chrome/tools/crash_service/caps/logger_win.h View 1 chunk +32 lines, -0 lines 0 comments Download
A chrome/tools/crash_service/caps/logger_win.cc View 1 chunk +90 lines, -0 lines 0 comments Download
A chrome/tools/crash_service/caps/main_win.cc View 1 chunk +36 lines, -0 lines 0 comments Download
A chrome/tools/crash_service/caps/process_singleton_win.h View 1 chunk +30 lines, -0 lines 0 comments Download
A chrome/tools/crash_service/caps/process_singleton_win.cc View 1 chunk +29 lines, -0 lines 0 comments Download
A chrome/tools/crash_service/crash_service.exe.manifest View 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/tools/crash_service/main.cc View 1 chunk +79 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Charlie Reis
Created Revert of Remove CAPS
4 years, 7 months ago (2016-04-26 22:28:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921973006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921973006/1
4 years, 7 months ago (2016-04-26 22:28:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-26 22:29:29 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6084075b5b792b3cf779a814b3fc089a07c331bd Cr-Commit-Position: refs/heads/master@{#389916}
4 years, 7 months ago (2016-04-26 22:30:55 UTC) #6
Dirk Pranke
4 years, 7 months ago (2016-04-26 22:38:41 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698