third_party/WebKit/Source/core/layout/TableLayoutAlgorithm.h - Issue 1921973005: [css tables] Don't pass table width increase due to % columns to parents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/TableLayoutAlgorithm.h

Issue 1921973005: [css tables] Don't pass table width increase due to % columns to parents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move variables around Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutTable.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutTable.cpp ('k') | third_party/WebKit/Source/core/layout/TableLayoutAlgorithmAuto.h » ('j') | third_party/WebKit/Source/core/layout/TableLayoutAlgorithmAuto.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/TableLayoutAlgorithm.h

diff --git a/third_party/WebKit/Source/core/layout/TableLayoutAlgorithm.h b/third_party/WebKit/Source/core/layout/TableLayoutAlgorithm.h

index ffc5cf4de6368dde22d52a48ff5d9f69d26f443f..50f7bbdc9364c1daaceb2c31543a3e5fe308916b 100644

--- a/third_party/WebKit/Source/core/layout/TableLayoutAlgorithm.h

+++ b/third_party/WebKit/Source/core/layout/TableLayoutAlgorithm.h

@@ -43,6 +43,7 @@ public:

virtual void applyPreferredLogicalWidthQuirks(LayoutUnit& minWidth, LayoutUnit& maxWidth) const = 0;

virtual void layout() = 0;

virtual void willChangeTableLayout() = 0;

+ virtual LayoutUnit scaledWidthFromPercentColumns() = 0;

mstensho (USE GERRIT) 2016/04/27 12:19:48 I don't think it's strictly necessary to make this

dgrogan 2016/04/27 20:24:05 Good call.

protected:

// FIXME: Once we enable SATURATED_LAYOUT_ARITHMETHIC, this should just be LayoutUnit::nearlyMax().