third_party/WebKit/LayoutTests/fast/table/table-size-integer-overflow.html - Issue 1921973005: [css tables] Don't pass table width increase due to % columns to parents

Unified Diff: third_party/WebKit/LayoutTests/fast/table/table-size-integer-overflow.html

Issue 1921973005: [css tables] Don't pass table width increase due to % columns to parents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move variables around Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/table/max-width-integer-overflow.html ('K') | « third_party/WebKit/LayoutTests/fast/table/max-width-integer-overflow-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/table/table-size-integer-overflow-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutTable.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/table/table-size-integer-overflow.html

diff --git a/third_party/WebKit/LayoutTests/fast/table/table-size-integer-overflow.html b/third_party/WebKit/LayoutTests/fast/table/table-size-integer-overflow.html

index 8ca40be0727eda0bd0261ec3b9cea89272314375..e4ff62990c7d9a837c34f355cab586b9461f114c 100644

--- a/third_party/WebKit/LayoutTests/fast/table/table-size-integer-overflow.html

+++ b/third_party/WebKit/LayoutTests/fast/table/table-size-integer-overflow.html

@@ -1,30 +1,15 @@

-<html>

-<head>

-<script>

-window.onload = function() {

- if (window.testRunner)

- window.testRunner.dumpAsText();

- var cell = document.getElementById("cell");

- var text = cell.firstElementChild;

- var wdiff = cell.offsetWidth - text.offsetWidth - (parseInt(window.getComputedStyle(cell).getPropertyValue('padding-right')) +

- parseInt(window.getComputedStyle(cell).getPropertyValue('padding-left')));

- if (wdiff > 0)

- text.innerText = "PASS";

-</script>

-</head>

-<body>

dgrogan 2016/04/27 03:14:04 The float makes a difference here but I am not yet

mstensho (USE GERRIT) 2016/04/27 12:19:48 An auto-width float is shrink-to-fit, which might

dgrogan 2016/04/27 20:24:05 Yeah, if that matches blink's current behavior and

- <table style="margin: 1px">

+ <table style="margin: 1px" data-expected-width="40">

<tr>

- <td id="cell" style="background-color: green; width: 100%; height: 30px">

- <span>FAIL</span>

+ <td id="cell" style="background-color: green; width: 100%; height: 30px" data-expected-width="32">

+ <div style="display:inline-block; width:30px;"></div>

</td>

</tr>

</table>

</div>

-<div style="clear: left;">The green box should be the full width of the page.</div>

-</body>

-</html>

+<div style="clear: left;">Edge 25.10586.0.0 shows the green box as the full width of the page. So did Blink before Chrome 52. FireFox 48 agrees with Chrome 52.</div>

dgrogan 2016/04/27 03:14:04 I am a little worried that this is a bellwether fo

mstensho (USE GERRIT) 2016/04/27 12:19:48 Diverging from Edge for table layout certainly doe

dgrogan 2016/04/27 20:24:05 Yeah, this one we also change behavior from Edge t

+<script src="../../resources/check-layout.js"></script>

+<script>

+checkLayout('table');

+</script>