Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: third_party/WebKit/Source/core/layout/TableLayoutAlgorithm.h

Issue 1921973005: [css tables] Don't pass table width increase due to % columns to parents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge ToT Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2002 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2002 Lars Knoll (knoll@kde.org)
3 * (C) 2002 Dirk Mueller (mueller@kde.org) 3 * (C) 2002 Dirk Mueller (mueller@kde.org)
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License. 8 * version 2 of the License.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of 11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13 * Library General Public License for more details. 13 * Library General Public License for more details.
14 * 14 *
15 * You should have received a copy of the GNU Library General Public License 15 * You should have received a copy of the GNU Library General Public License
16 * along with this library; see the file COPYING.LIB. If not, write to 16 * along with this library; see the file COPYING.LIB. If not, write to
17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
18 * Boston, MA 02110-1301, USA. 18 * Boston, MA 02110-1301, USA.
19 */ 19 */
20 20
21 #ifndef TableLayoutAlgorithm_h 21 #ifndef TableLayoutAlgorithm_h
22 #define TableLayoutAlgorithm_h 22 #define TableLayoutAlgorithm_h
23 23
24 #include "platform/LayoutUnit.h"
24 #include "wtf/Allocator.h" 25 #include "wtf/Allocator.h"
25 #include "wtf/Noncopyable.h" 26 #include "wtf/Noncopyable.h"
26 27
27 namespace blink { 28 namespace blink {
28 29
29 class LayoutUnit;
30 class LayoutTable; 30 class LayoutTable;
31 31
32 class TableLayoutAlgorithm { 32 class TableLayoutAlgorithm {
33 WTF_MAKE_NONCOPYABLE(TableLayoutAlgorithm); USING_FAST_MALLOC(TableLayoutAlg orithm); 33 WTF_MAKE_NONCOPYABLE(TableLayoutAlgorithm); USING_FAST_MALLOC(TableLayoutAlg orithm);
34 public: 34 public:
35 explicit TableLayoutAlgorithm(LayoutTable* table) 35 explicit TableLayoutAlgorithm(LayoutTable* table)
36 : m_table(table) 36 : m_table(table)
37 { 37 {
38 } 38 }
39 39
40 virtual ~TableLayoutAlgorithm() { } 40 virtual ~TableLayoutAlgorithm() { }
41 41
42 virtual void computeIntrinsicLogicalWidths(LayoutUnit& minWidth, LayoutUnit& maxWidth) = 0; 42 virtual void computeIntrinsicLogicalWidths(LayoutUnit& minWidth, LayoutUnit& maxWidth) = 0;
43 virtual LayoutUnit scaledWidthFromPercentColumns()
44 {
45 return LayoutUnit(0);
46 }
43 virtual void applyPreferredLogicalWidthQuirks(LayoutUnit& minWidth, LayoutUn it& maxWidth) const = 0; 47 virtual void applyPreferredLogicalWidthQuirks(LayoutUnit& minWidth, LayoutUn it& maxWidth) const = 0;
44 virtual void layout() = 0; 48 virtual void layout() = 0;
45 virtual void willChangeTableLayout() = 0; 49 virtual void willChangeTableLayout() = 0;
46 50
47 protected: 51 protected:
48 // FIXME: Once we enable SATURATED_LAYOUT_ARITHMETHIC, this should just be L ayoutUnit::nearlyMax(). 52 // FIXME: Once we enable SATURATED_LAYOUT_ARITHMETHIC, this should just be L ayoutUnit::nearlyMax().
49 // Until then though, using nearlyMax causes overflow in some tests, so we j ust pick a large number. 53 // Until then though, using nearlyMax causes overflow in some tests, so we j ust pick a large number.
50 const static int tableMaxWidth = 1000000; 54 const static int tableMaxWidth = 1000000;
51 55
52 LayoutTable* m_table; 56 LayoutTable* m_table;
53 }; 57 };
54 58
55 } // namespace blink 59 } // namespace blink
56 60
57 #endif // TableLayoutAlgorithm_h 61 #endif // TableLayoutAlgorithm_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698