third_party/WebKit/Source/core/layout/TableLayoutAlgorithmAuto.h - Issue 1921973005: [css tables] Don't pass table width increase due to % columns to parents

Side by Side Diff: third_party/WebKit/Source/core/layout/TableLayoutAlgorithmAuto.h

Issue 1921973005: [css tables] Don't pass table width increase due to % columns to parents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: naively pass scaled width to non-table parents Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/table/inner-percent-width-doesnt-affect-ancestor-columns.html ('K') | « third_party/WebKit/Source/core/layout/TableLayoutAlgorithm.h ('k') | third_party/WebKit/Source/core/layout/TableLayoutAlgorithmAuto.cpp » ('j') | third_party/WebKit/Source/core/layout/TableLayoutAlgorithmAuto.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2002 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 2002 Lars Knoll (knoll@kde.org)

3 * (C) 2002 Dirk Mueller (mueller@kde.org)	3 * (C) 2002 Dirk Mueller (mueller@kde.org)

4 *	4 *

5 * This library is free software; you can redistribute it and/or	5 * This library is free software; you can redistribute it and/or

6 * modify it under the terms of the GNU Library General Public	6 * modify it under the terms of the GNU Library General Public

7 * License as published by the Free Software Foundation; either	7 * License as published by the Free Software Foundation; either

8 * version 2 of the License.	8 * version 2 of the License.

9 *	9 *

10 * This library is distributed in the hope that it will be useful,	10 * This library is distributed in the hope that it will be useful,

(...skipping 36 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
47 StartToEnd,	47 StartToEnd,

48 EndToStart	48 EndToStart

49 };	49 };

50	50

51 class TableLayoutAlgorithmAuto final : public TableLayoutAlgorithm {	51 class TableLayoutAlgorithmAuto final : public TableLayoutAlgorithm {

52 public:	52 public:

53 TableLayoutAlgorithmAuto(LayoutTable*);	53 TableLayoutAlgorithmAuto(LayoutTable*);

54 ~TableLayoutAlgorithmAuto() override;	54 ~TableLayoutAlgorithmAuto() override;

55	55

56 void computeIntrinsicLogicalWidths(LayoutUnit& minWidth, LayoutUnit& maxWidt h) override;	56 void computeIntrinsicLogicalWidths(LayoutUnit& minWidth, LayoutUnit& maxWidt h) override;

	57 LayoutUnit scaledWidthFromPercentColumns() override;

57 void applyPreferredLogicalWidthQuirks(LayoutUnit& minWidth, LayoutUnit& maxW idth) const override;	58 void applyPreferredLogicalWidthQuirks(LayoutUnit& minWidth, LayoutUnit& maxW idth) const override;

58 void layout() override;	59 void layout() override;

59 void willChangeTableLayout() override { }	60 void willChangeTableLayout() override { }

60	61

61 private:	62 private:

62 void fullRecalc();	63 void fullRecalc();

63 void recalcColumn(unsigned effCol);	64 void recalcColumn(unsigned effCol);

64	65

65 int calcEffectiveLogicalWidth();	66 int calcEffectiveLogicalWidth();

66 void shrinkColumnWidth(const LengthType&, int& available);	67 void shrinkColumnWidth(const LengthType&, int& available);

(...skipping 27 matching lines...) Expand all Loading...
94	95

95 Vector<Layout, 4> m_layoutStruct;	96 Vector<Layout, 4> m_layoutStruct;

96 Vector<LayoutTableCell*, 4> m_spanCells;	97 Vector<LayoutTableCell*, 4> m_spanCells;

97 bool m_hasPercent : 1;	98 bool m_hasPercent : 1;

98 mutable bool m_effectiveLogicalWidthDirty : 1;	99 mutable bool m_effectiveLogicalWidthDirty : 1;

99 };	100 };

100	101

101 } // namespace blink	102 } // namespace blink

102	103

103 #endif // TableLayoutAlgorithmAuto	104 #endif // TableLayoutAlgorithmAuto

OLD	NEW