Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1921973004: Moves DefaultWindowResizer to common. (Closed)

Created:
4 years, 7 months ago by sky
Modified:
4 years, 7 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@first_move
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves DefaultWindowResizer to common. And nukes unnecessary include. BUG=603369 TEST=covered by tests R=jamescook@chromium.org Committed: https://crrev.com/e6f19e8f16f92ff230944da6bb451e1553e0615a Cr-Commit-Position: refs/heads/master@{#389950}

Patch Set 1 #

Patch Set 2 : merge 2 trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -119 lines) Patch
M ash/ash.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
A + ash/wm/common/default_window_resizer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/wm/common/default_window_resizer.cc View 3 chunks +4 lines, -5 lines 0 comments Download
D ash/wm/default_window_resizer.h View 1 chunk +0 lines, -53 lines 0 comments Download
D ash/wm/default_window_resizer.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M ash/wm/dock/docked_window_resizer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 2 chunks +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 1921423002 Patch 20001

Messages

Total messages: 7 (2 generated)
sky
4 years, 7 months ago (2016-04-26 19:56:37 UTC) #1
James Cook
LGTM. Hooray for getting rid of unnecessary includes!
4 years, 7 months ago (2016-04-26 23:30:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921973004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921973004/20001
4 years, 7 months ago (2016-04-26 23:42:38 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-27 00:11:58 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 00:13:31 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e6f19e8f16f92ff230944da6bb451e1553e0615a
Cr-Commit-Position: refs/heads/master@{#389950}

Powered by Google App Engine
This is Rietveld 408576698