components/error_page/common/error_page_params.h - Issue 1921973002: Convert //components/[a-e]* from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/error_page/common/error_page_params.h

Issue 1921973002: Convert //components/[a-e]* from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/devtools_http_handler/devtools_http_handler.cc ('K') | « components/devtools_http_handler/devtools_http_handler_unittest.cc ('k') | components/error_page/common/localized_error.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/error_page/common/error_page_params.h

diff --git a/components/error_page/common/error_page_params.h b/components/error_page/common/error_page_params.h

index c0b2203b9011a07ab8b40a09cf3a1ba183349ba8..6aa9e1745c9bd4bdd6cd7520733abfcd52ca9972 100644

--- a/components/error_page/common/error_page_params.h

+++ b/components/error_page/common/error_page_params.h

@@ -5,9 +5,9 @@

#ifndef COMPONENTS_NET_ERROR_COMMON_ERROR_PAGE_PARAMS_H_

#define COMPONENTS_NET_ERROR_COMMON_ERROR_PAGE_PARAMS_H_

+#include <memory>

#include <string>

-#include "base/memory/scoped_ptr.h"

#include "url/gurl.h"

namespace base {

@@ -29,7 +29,7 @@ struct ErrorPageParams {

// contains a "header" entry. A "body" entry may optionally be specified.

// JSTemplate evaluation will be applied when added to the DOM. If NULL, the

// default suggestions will be used.

- scoped_ptr<base::ListValue> override_suggestions;

+ std::unique_ptr<base::ListValue> override_suggestions;

// Prefix to prepend to search terms. Search box is only shown if this is

// a valid url. The search terms will be appended to the end of this URL to