Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1921943002: doc: General improvements. (Closed)

Created:
4 years, 8 months ago by martiniss
Modified:
4 years, 6 months ago
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/recipes-py@master
Target Ref:
refs/heads/master
Project:
recipes-py
Visibility:
Public.

Description

doc: General improvements. Print the argument list, alphabetize packages. BUG= Committed: https://github.com/luci/recipes-py/commit/9262aad64311ff326e911dcfafd257bf4d082436

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase license. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -8 lines) Patch
M recipe_engine/doc.py View 1 1 chunk +19 lines, -5 lines 0 comments Download
M recipe_engine/loader.py View 1 2 chunks +10 lines, -1 line 0 comments Download
M recipe_engine/recipe_api.py View 1 3 chunks +3 lines, -1 line 0 comments Download
M recipes.py View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
martiniss
PTAL https://codereview.chromium.org/1921943002/diff/1/recipe_engine/recipe_api.py File recipe_engine/recipe_api.py (right): https://codereview.chromium.org/1921943002/diff/1/recipe_engine/recipe_api.py#newcode237 recipe_engine/recipe_api.py:237: _inner.__original = func Umm. Is this legit? It ...
4 years, 8 months ago (2016-04-25 23:44:19 UTC) #2
martiniss
ping
4 years, 6 months ago (2016-05-27 23:13:45 UTC) #4
iannucci
lgtm https://chromiumcodereview.appspot.com/1921943002/diff/1/recipe_engine/recipe_api.py File recipe_engine/recipe_api.py (right): https://chromiumcodereview.appspot.com/1921943002/diff/1/recipe_engine/recipe_api.py#newcode237 recipe_engine/recipe_api.py:237: _inner.__original = func On 2016/04/25 23:44:19, martiniss wrote: ...
4 years, 6 months ago (2016-05-28 00:38:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921943002/1
4 years, 6 months ago (2016-05-31 17:14:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Recipes-py Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Recipes-py%20Presubmit/builds/260)
4 years, 6 months ago (2016-05-31 17:17:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921943002/20001
4 years, 6 months ago (2016-05-31 17:53:23 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 17:55:19 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://github.com/luci/recipes-py/commit/9262aad64311ff326e911dcfafd257bf4d0...

Powered by Google App Engine
This is Rietveld 408576698