Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Issue 1921933004: More consistency in m_v_s_bridge.cc. (Closed)

Created:
4 years, 8 months ago by sfiera
Modified:
4 years, 8 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

More consistency in m_v_s_bridge.cc. Vectors by reservation only. No pushing. BUG=603026 Committed: https://crrev.com/e1f161a43ad6973cdc3494a132e5c18e7874db50 Cr-Commit-Position: refs/heads/master@{#390020}

Patch Set 1 #

Patch Set 2 : Protected destructor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M chrome/browser/android/ntp/most_visited_sites.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/android/ntp/most_visited_sites_bridge.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
sfiera
4 years, 8 months ago (2016-04-26 15:04:11 UTC) #2
Bernhard Bauer
LGTM, thanks!
4 years, 8 months ago (2016-04-26 15:16:03 UTC) #3
sfiera
Added the protected destructor, too (access seems fine). I'm going to assume your LGTM still ...
4 years, 8 months ago (2016-04-26 15:18:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921933004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921933004/20001
4 years, 8 months ago (2016-04-26 15:18:43 UTC) #7
Bernhard Bauer
I'd be happy to re-LGTM it, but this works :)
4 years, 8 months ago (2016-04-26 15:19:39 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/60349)
4 years, 8 months ago (2016-04-26 16:32:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921933004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921933004/20001
4 years, 8 months ago (2016-04-27 07:49:56 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-27 08:21:00 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-27 08:22:52 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e1f161a43ad6973cdc3494a132e5c18e7874db50
Cr-Commit-Position: refs/heads/master@{#390020}

Powered by Google App Engine
This is Rietveld 408576698