components/security_interstitials/core/metrics_helper.cc - Issue 1921923002: Convert //components/[o-t]* from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/security_interstitials/core/metrics_helper.cc

Issue 1921923002: Convert //components/[o-t]* from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/security_interstitials/core/controller_client.cc ('k') | components/session_manager/core/session_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/security_interstitials/core/metrics_helper.cc

diff --git a/components/security_interstitials/core/metrics_helper.cc b/components/security_interstitials/core/metrics_helper.cc

index d55a37caf5aa0428a3fc9b2498f449d1fec99fcd..ee1724c29431dd3d1242c8d914dfc888bb1ddad1 100644

--- a/components/security_interstitials/core/metrics_helper.cc

+++ b/components/security_interstitials/core/metrics_helper.cc

@@ -4,6 +4,7 @@

#include "components/security_interstitials/core/metrics_helper.h"

+#include <memory>

#include <utility>

#include "base/metrics/histogram.h"

@@ -166,7 +167,7 @@ void MetricsHelper::RecordUserDecisionToRappor(Decision decision) {

if (!rappor_service_ || (decision != PROCEED && decision != DONT_PROCEED))

return;

- scoped_ptr<rappor::Sample> sample =

+ std::unique_ptr<rappor::Sample> sample =

rappor_service_->CreateSample(settings_.rappor_report_type);

// This will populate, for example, "intersitial.malware.domain" or

« no previous file with comments | « components/security_interstitials/core/controller_client.cc ('k') | components/session_manager/core/session_manager.h » ('j') | no next file with comments »