components/page_load_metrics/renderer/metrics_render_frame_observer.cc - Issue 1921923002: Convert //components/[o-t]* from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/renderer/metrics_render_frame_observer.cc

Issue 1921923002: Convert //components/[o-t]* from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/page_load_metrics/renderer/metrics_render_frame_observer.h ('k') | components/page_load_metrics/renderer/metrics_render_frame_observer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/renderer/metrics_render_frame_observer.cc

diff --git a/components/page_load_metrics/renderer/metrics_render_frame_observer.cc b/components/page_load_metrics/renderer/metrics_render_frame_observer.cc

index 311d857a2066b369c15323c41cb789cb835d96de..aa146925d713a073770466c226e75f2d16c10c43 100644

--- a/components/page_load_metrics/renderer/metrics_render_frame_observer.cc

+++ b/components/page_load_metrics/renderer/metrics_render_frame_observer.cc

@@ -6,6 +6,7 @@

#include <string>

+#include "base/memory/ptr_util.h"

#include "base/time/time.h"

#include "base/timer/timer.h"

#include "components/page_load_metrics/renderer/page_timing_metrics_sender.h"

@@ -136,8 +137,8 @@ PageLoadTiming MetricsRenderFrameObserver::GetTiming() const {

return timing;

}

-scoped_ptr<base::Timer> MetricsRenderFrameObserver::CreateTimer() const {

- return make_scoped_ptr(new base::OneShotTimer);

+std::unique_ptr<base::Timer> MetricsRenderFrameObserver::CreateTimer() const {

+ return base::WrapUnique(new base::OneShotTimer);

}

bool MetricsRenderFrameObserver::HasNoRenderFrame() const {