chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js - Issue 1921913002: MD Settings; Lazy instantiate Clear Browsing Data dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js

Issue 1921913002: MD Settings; Lazy instantiate Clear Browsing Data dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update test. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/settings/privacy_page/privacy_page.html » ('j') | chrome/browser/resources/settings/privacy_page/privacy_page.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js

diff --git a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js

index 381b54fa47a5c5139a48b213d48722df2b386254..c14e51eaa0ec6e60d5309447303d483f5af237aa 100644

--- a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js

+++ b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js

@@ -51,6 +51,7 @@ Polymer({

this.setAllowDeletingHistory_.bind(this));

this.browserProxy_ =

settings.ClearBrowsingDataBrowserProxyImpl.getInstance();

+ this.$.dialog.open();

/**

@@ -66,10 +67,6 @@ Polymer({

}

- open: function() {

- this.$.dialog.open();

- },

/** @private */

onClearBrowsingDataTap_: function() {

this.clearingInProgress_ = true;