pkg/path/lib/path.dart - Issue 19219002: Test empty strings arguments to path.join().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/path/lib/path.dart

Issue 19219002: Test empty strings arguments to path.join(). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Handle trailing empty string args in path.join(). Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/path/lib/path.dart

diff --git a/pkg/path/lib/path.dart b/pkg/path/lib/path.dart

index b425124cd42e2e86055998bd3fc13004cb66f080..25ce0e6fb850199240b4d00d90f72bd92a12449c 100644

--- a/pkg/path/lib/path.dart

+++ b/pkg/path/lib/path.dart

@@ -525,7 +525,7 @@ class Builder {

var needsSeparator = false;

var isAbsoluteAndNotRootRelative = false;

- for (var part in parts) {

+ for (var part in parts.where((part) => part != '')) {

if (this.isRootRelative(part) && isAbsoluteAndNotRootRelative) {

// If the new part is root-relative, it preserves the previous root but

// replaces the path after it.

« no previous file with comments | « no previous file | pkg/path/test/posix_test.dart » ('j') | no next file with comments »