Chromium Code Reviews| Index: appengine/findit/handlers/build_failure.py |
| diff --git a/appengine/findit/handlers/build_failure.py b/appengine/findit/handlers/build_failure.py |
| index 16245b68fc64e27ffe65911c5501500704b58260..3f6eca31bd1b5635d8836b5401d77e32468c43b6 100644 |
| --- a/appengine/findit/handlers/build_failure.py |
| +++ b/appengine/findit/handlers/build_failure.py |
| @@ -253,11 +253,12 @@ def _GetAnalysisResultWithTryJobInfo( |
| 'supported': heuristic_result['supported'] |
| } |
| - if try_job_result['status'] == result_status.FLAKY: |
| - step_updated_results['flaky_failures'].append(final_result) |
| - elif try_job_result['status'] in NO_TRY_JOB_REASON_MAP.values(): |
| + if ('status' not in try_job_result or |
|
lijeffrey
2016/04/26 21:53:29
Maybe add a test case for this?
stgao
2016/04/26 22:05:46
+1
chanli
2016/04/26 22:29:15
Done.
|
| + try_job_result['status'] in NO_TRY_JOB_REASON_MAP.values()): |
| # There is no try job info but only heuristic result. |
| step_updated_results['unclassified_failures'].append(final_result) |
| + elif try_job_result['status'] == result_status.FLAKY: |
| + step_updated_results['flaky_failures'].append(final_result) |
| else: |
| step_updated_results['reliable_failures'].append(final_result) |