Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1921863002: Listen for changes in the context folder. (Closed)

Created:
4 years, 8 months ago by scheglov
Modified:
4 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Listen for changes in the context folder. I had to convert several static methods into instance ones becuse I'd like to use PathContext from the ResourceProvider. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c9068a8692d49913720f52751cc52b4bf155eede

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -94 lines) Patch
M pkg/analysis_server/lib/src/single_context_manager.dart View 14 chunks +176 lines, -77 lines 0 comments Download
M pkg/analysis_server/test/single_context_manager_test.dart View 5 chunks +127 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 8 months ago (2016-04-25 20:32:38 UTC) #1
Brian Wilkerson
lgtm
4 years, 8 months ago (2016-04-25 20:39:47 UTC) #2
scheglov
4 years, 8 months ago (2016-04-25 20:51:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c9068a8692d49913720f52751cc52b4bf155eede (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698