Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1921853005: [debugger,interpreter] precisely determine execution tier. (Closed)

Created:
4 years, 7 months ago by Yang
Modified:
4 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger,interpreter] precisely determine execution tier. R=mstarzinger@chromium.org BUG=v8:4690 LOG=N Committed: https://crrev.com/c2186834942d79b0575d8357fd835535083916d6 Cr-Commit-Position: refs/heads/master@{#35840}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -9 lines) Patch
M src/compiler.cc View 3 chunks +7 lines, -1 line 0 comments Download
M src/debug/debug.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 2 chunks +10 lines, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
4 years, 7 months ago (2016-04-27 13:33:26 UTC) #1
Michael Starzinger
LGTM as a temporary solution to unblock debugger work.
4 years, 7 months ago (2016-04-27 16:24:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921853005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921853005/1
4 years, 7 months ago (2016-04-28 05:37:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 06:17:49 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:01:42 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c2186834942d79b0575d8357fd835535083916d6
Cr-Commit-Position: refs/heads/master@{#35840}

Powered by Google App Engine
This is Rietveld 408576698