Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1921853004: Move the ScriptForbiddenScope in TreeScope::adoptIfNeeded to the top of the function. (Closed)

Created:
4 years, 7 months ago by Mariusz Mlynski
Modified:
4 years, 7 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move the ScriptForbiddenScope in TreeScope::adoptIfNeeded to the top of the function. This patch addresses the review comments and adds an automated test. BUG=605766 Committed: https://crrev.com/34d3807c8e69adcd5ac23f45572ccb83684d1dc1 Cr-Commit-Position: refs/heads/master@{#390885}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressing comments + a whitespace fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/fast/events/image-adoption-events.html View 1 1 chunk +46 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/events/image-adoption-events-expected.txt View 1 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/TreeScope.cpp View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Mariusz Mlynski
PTAL. @esprehn: I've moved the ScriptForbiddenScope to the top. @dcheng: I've added the comment for ...
4 years, 7 months ago (2016-04-26 19:38:04 UTC) #2
esprehn
https://codereview.chromium.org/1921853004/diff/1/third_party/WebKit/LayoutTests/fast/events/image-adoption-events-expected.txt File third_party/WebKit/LayoutTests/fast/events/image-adoption-events-expected.txt (right): https://codereview.chromium.org/1921853004/diff/1/third_party/WebKit/LayoutTests/fast/events/image-adoption-events-expected.txt#newcode1 third_party/WebKit/LayoutTests/fast/events/image-adoption-events-expected.txt:1: FAIL: readystatechange event was dispatched but the handler was ...
4 years, 7 months ago (2016-04-26 20:17:18 UTC) #3
Mariusz Mlynski
https://codereview.chromium.org/1921853004/diff/1/third_party/WebKit/LayoutTests/fast/events/image-adoption-events-expected.txt File third_party/WebKit/LayoutTests/fast/events/image-adoption-events-expected.txt (right): https://codereview.chromium.org/1921853004/diff/1/third_party/WebKit/LayoutTests/fast/events/image-adoption-events-expected.txt#newcode1 third_party/WebKit/LayoutTests/fast/events/image-adoption-events-expected.txt:1: FAIL: readystatechange event was dispatched but the handler was ...
4 years, 7 months ago (2016-04-26 20:35:58 UTC) #4
Mariusz Mlynski
On 2016/04/26 20:17:18, esprehn wrote: > https://codereview.chromium.org/1921853004/diff/1/third_party/WebKit/LayoutTests/fast/events/image-adoption-events.html#newcode1 > third_party/WebKit/LayoutTests/fast/events/image-adoption-events.html:1: <html> > Add doctype, you can ...
4 years, 7 months ago (2016-04-26 22:14:33 UTC) #6
dominicc (has gone to gerrit)
lgtm
4 years, 7 months ago (2016-05-02 01:15:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921853004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921853004/40001
4 years, 7 months ago (2016-05-02 01:15:15 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 7 months ago (2016-05-02 02:15:21 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 02:16:42 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/34d3807c8e69adcd5ac23f45572ccb83684d1dc1
Cr-Commit-Position: refs/heads/master@{#390885}

Powered by Google App Engine
This is Rietveld 408576698