build/config/win/BUILD.gn - Issue 1921853002: Replacing hard-coded clang version by a common variable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/win/BUILD.gn

Issue 1921853002: Replacing hard-coded clang version by a common variable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: setting clang_version only when is_clang==true. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/win/BUILD.gn

diff --git a/build/config/win/BUILD.gn b/build/config/win/BUILD.gn

index 8b40bd452c6ee75e4efdce2db04dc6eff971e69f..4b42e337d3beaede0581ebb584873d78e3ca11fc 100644

--- a/build/config/win/BUILD.gn

+++ b/build/config/win/BUILD.gn

@@ -95,7 +95,7 @@ config("compiler") {

}

# Clang runtime libraries, such as the sanitizer runtimes, live here.

- lib_dirs = [ "//third_party/llvm-build/Release+Asserts/lib/clang/3.9.0/lib/windows" ]

+ lib_dirs = [ "//third_party/llvm-build/Release+Asserts/lib/clang/$clang_version/lib/windows" ]

}

if (is_syzyasan) {

« no previous file with comments | « base/BUILD.gn ('k') | build/toolchain/toolchain.gni » ('j') | build/toolchain/toolchain.gni » ('J')