Issue 1921823007: Make types concrete when checking overrides.

Issue 1921823007: Make types concrete when checking overrides. (Closed)

Created:
4 years, 7 months ago by Leaf

Modified:
4 years, 7 months ago

Reviewers:
Jennifer Messerly, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Make types concrete when checking overrides. Override checking for methods should treat dynamic parameters as top, not as bottom. Fixes #26077 Fixes #26151 Fixes #26174 BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/a781ab9a7d201415d573368ccece7b898137dae5

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+124 lines, -13 lines)			Patch
M	pkg/analyzer/lib/src/generated/error_verifier.dart	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/task/strong/checker.dart	View		3 chunks	+20 lines, -5 lines	0 comments	Download
M	pkg/analyzer/test/src/task/strong/checker_test.dart	View	1	5 chunks	+97 lines, -7 lines	0 comments	Download
M	pkg/analyzer/test/src/task/strong/inferred_type_test.dart	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

Leaf

Committed patchset #3 (id:40001) manually as a781ab9a7d201415d573368ccece7b898137dae5 (presubmit successful).

4 years, 7 months ago (2016-04-28 15:47:57 UTC) #5

Message was sent while issue was closed.

LGTM!