Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 1921823005: More <settings-dialog> tweaks to match the spec. (Closed)

Created:
4 years, 8 months ago by dpapad
Modified:
4 years, 7 months ago
Reviewers:
dschuyler
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

More <settings-dialog> tweaks to match the spec. - Change dialog body and buttons font to 13px. - Change button container padding from 24px to 16px. - Add 2px border radius around dialog. BUG=595804 Committed: https://crrev.com/3ca59f87d882632c9bb47acb15fcbc3d337f8282 Cr-Commit-Position: refs/heads/master@{#389918}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M chrome/browser/resources/settings/settings_dialog.html View 3 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dpapad
Before after screenshots at http://imgur.com/a/WmgET. This is addressing most of Alan's comments at https://bugs.chromium.org/p/chromium/issues/detail?id=595804#c10.
4 years, 8 months ago (2016-04-26 21:12:58 UTC) #3
dschuyler
lgtm
4 years, 8 months ago (2016-04-26 21:18:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921823005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921823005/1
4 years, 8 months ago (2016-04-26 21:38:42 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-26 22:33:35 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-04-26 22:35:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ca59f87d882632c9bb47acb15fcbc3d337f8282
Cr-Commit-Position: refs/heads/master@{#389918}

Powered by Google App Engine
This is Rietveld 408576698