import supervised users browser-tests

import supervised users browser-tests

BUG=563722
Committed: https://crrev.com/9ca35a43b0620dc931658c71d49a27b238848f37
Cr-Commit-Position: refs/heads/master@{#390940}

[Moe, 2016-04-25 18:39:37]

Description was changed from

==========
import supervised users browser-tests

Signed-off-by: mahmadi <mahmadi@chromium.org>

BUG=563722
==========

to

==========
import supervised users browser-tests

BUG=563722
==========

[Moe, 2016-04-25 18:40:00]

mahmadi@chromium.org changed reviewers:
+ dbeam@chromium.org

[Moe, 2016-04-25 18:40:43]

Hi Dan, Please review the browser tests for the import supervised user dialog in
the Desktop User Manager.

[Moe, 2016-04-27 19:22:41]

mahmadi@chromium.org changed reviewers:
+ bauerb@chromium.org

[Moe, 2016-04-27 19:27:41]

mahmadi@chromium.org changed reviewers:
+ achuith@chromium.org
- bauerb@chromium.org, dbeam@chromium.org

[Moe, 2016-04-27 19:27:42]

Hi Achuith, Could you please take a look it this patch? Thank you!

[achuithb, 2016-04-27 21:30:38]

achuith@chromium.org changed reviewers:
+ dbeam@chromium.org, michaelpg@chromium.org

[achuithb, 2016-04-27 21:30:39]

Dan, Michael, could one of you review this? I don't know much about polymer.

[achuithb, 2016-04-27 21:30:47]

The CQ bit was checked by achuith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 21:31:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921783002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921783002/1

[commit-bot: I haz the power, 2016-04-27 22:36:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 22:36:47]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Moe, 2016-04-28 19:52:08]

mahmadi@chromium.org changed reviewers:
- achuith@chromium.org, dbeam@chromium.org

[Moe, 2016-04-28 19:53:26]

Michael, please review these changes when you have time.

[michaelpg, 2016-04-29 20:53:48]

https://codereview.chromium.org/1921783002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_user_manager/import_supervised_user_tests.js
(right):

https://codereview.chromium.org/1921783002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_user_manager/import_supervised_user_tests.js:11: /**
@return {string} */
nit: if you're going to annotate these, annotate the params as well, eg "@param
{!HTMLElement} element"

https://codereview.chromium.org/1921783002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_user_manager/import_supervised_user_tests.js:42:
importElement.show({}, []);
use a fake user here like in the next test. it's unclear why {} should result in
the dialog opening (tests shouldn't rely on unspecified implementation details)

https://codereview.chromium.org/1921783002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_user_manager/import_supervised_user_tests.js:46:
assertEquals('', importElement.$$('#backdrop').style.display);
here & below: check offsetHeight instead of style.display -- it's more reliable
(forces a style recalc) and isn't dependent on how you hide the element

https://codereview.chromium.org/1921783002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_user_manager/import_supervised_user_tests.js:49:
assertEquals(importElement.i18n('noSupervisedUserImportText'),
opt nit (here & below): compare against loadTimeData.getString instead of
importElement.i18n. otherwise if importElement.i18n started returning incorrect
strings this could still pass

https://codereview.chromium.org/1921783002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_user_manager/import_supervised_user_tests.js:141: //
Simulate clicking 'Import'
nit: ending period

[Moe, 2016-04-29 21:58:36]

https://codereview.chromium.org/1921783002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_user_manager/import_supervised_user_tests.js
(right):

https://codereview.chromium.org/1921783002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_user_manager/import_supervised_user_tests.js:11: /**
@return {string} */
On 2016/04/29 20:53:48, michaelpg wrote:
> nit: if you're going to annotate these, annotate the params as well, eg
"@param
> {!HTMLElement} element"

Done.

https://codereview.chromium.org/1921783002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_user_manager/import_supervised_user_tests.js:42:
importElement.show({}, []);
On 2016/04/29 20:53:48, michaelpg wrote:
> use a fake user here like in the next test. it's unclear why {} should result
in
> the dialog opening (tests shouldn't rely on unspecified implementation
details)

Done.

https://codereview.chromium.org/1921783002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_user_manager/import_supervised_user_tests.js:46:
assertEquals('', importElement.$$('#backdrop').style.display);
On 2016/04/29 20:53:47, michaelpg wrote:
> here & below: check offsetHeight instead of style.display -- it's more
reliable
> (forces a style recalc) and isn't dependent on how you hide the element

Done.

https://codereview.chromium.org/1921783002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_user_manager/import_supervised_user_tests.js:49:
assertEquals(importElement.i18n('noSupervisedUserImportText'),
On 2016/04/29 20:53:48, michaelpg wrote:
> opt nit (here & below): compare against loadTimeData.getString instead of
> importElement.i18n. otherwise if importElement.i18n started returning
incorrect
> strings this could still pass

Done.

[michaelpg, 2016-04-29 23:24:43]

lgtm

[Moe, 2016-05-02 13:44:12]

The CQ bit was checked by mahmadi@chromium.org

[Moe, 2016-05-02 13:44:26]

Thank you.

[commit-bot: I haz the power, 2016-05-02 13:44:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921783002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921783002/40001

[commit-bot: I haz the power, 2016-05-02 14:51:17]

Description was changed from

==========
import supervised users browser-tests

BUG=563722
==========

to

==========
import supervised users browser-tests

BUG=563722
==========

[commit-bot: I haz the power, 2016-05-02 14:51:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-02 14:52:47]

Description was changed from

==========
import supervised users browser-tests

BUG=563722
==========

to

==========
import supervised users browser-tests

BUG=563722

Committed: https://crrev.com/9ca35a43b0620dc931658c71d49a27b238848f37
Cr-Commit-Position: refs/heads/master@{#390940}
==========

[commit-bot: I haz the power, 2016-05-02 14:52:48]

Patchset 3 (id:??) landed as
https://crrev.com/9ca35a43b0620dc931658c71d49a27b238848f37
Cr-Commit-Position: refs/heads/master@{#390940}