Removing debugging information for NSS and Valgrind Suppressions

Removing debugging information for NSS and Valgrind Suppressions

Since we no longer use NSS for SSL/Crypto, the debugging information
for it is outdated and we no longer need to include the Valgrind
Suppressions.

BUG=604728
Committed: https://crrev.com/72b40a33f27d3fb1757508c53cc7ffafa9e0d1bb
Cr-Commit-Position: refs/heads/master@{#389808}

[svaldez, 2016-04-25 16:15:05]

svaldez@chromium.org changed reviewers:
+ davidben@chromium.org, rsleevi@chromium.org

[davidben, 2016-04-25 16:26:34]

https://codereview.chromium.org/1921743002/diff/1/docs/linux_debugging_ssl.md
File docs/linux_debugging_ssl.md (left):

https://codereview.chromium.org/1921743002/diff/1/docs/linux_debugging_ssl.md...
docs/linux_debugging_ssl.md:89: *   `SSLClientSocketNSS` can log its state
transitions and function calls using
SSLClientSocketOpenSSL has the same snippet. I don't know if we've ever used it,
but meh.

https://codereview.chromium.org/1921743002/diff/1/tools/valgrind/drmemory/sup...
File tools/valgrind/drmemory/suppressions_full.txt (right):

https://codereview.chromium.org/1921743002/diff/1/tools/valgrind/drmemory/sup...
tools/valgrind/drmemory/suppressions_full.txt:1353: name=http://crbug.com/70062
I think you want to take this entire suppression away.

https://codereview.chromium.org/1921743002/diff/1/tools/valgrind/drmemory/sup...
tools/valgrind/drmemory/suppressions_full.txt:1407: LEAK
Ditto.

[svaldez, 2016-04-25 19:40:59]

https://codereview.chromium.org/1921743002/diff/1/docs/linux_debugging_ssl.md
File docs/linux_debugging_ssl.md (left):

https://codereview.chromium.org/1921743002/diff/1/docs/linux_debugging_ssl.md...
docs/linux_debugging_ssl.md:89: *   `SSLClientSocketNSS` can log its state
transitions and function calls using
On 2016/04/25 16:26:34, davidben wrote:
> SSLClientSocketOpenSSL has the same snippet. I don't know if we've ever used
it,
> but meh.

Done.

https://codereview.chromium.org/1921743002/diff/1/tools/valgrind/drmemory/sup...
File tools/valgrind/drmemory/suppressions_full.txt (right):

https://codereview.chromium.org/1921743002/diff/1/tools/valgrind/drmemory/sup...
tools/valgrind/drmemory/suppressions_full.txt:1353: name=http://crbug.com/70062
On 2016/04/25 16:26:34, davidben wrote:
> I think you want to take this entire suppression away.

Done.

https://codereview.chromium.org/1921743002/diff/1/tools/valgrind/drmemory/sup...
tools/valgrind/drmemory/suppressions_full.txt:1407: LEAK
On 2016/04/25 16:26:34, davidben wrote:
> Ditto.

Done.

[davidben, 2016-04-25 19:50:04]

lgtm

https://codereview.chromium.org/1921743002/diff/20001/docs/linux_debugging_ss...
File docs/linux_debugging_ssl.md (right):

https://codereview.chromium.org/1921743002/diff/20001/docs/linux_debugging_ss...
docs/linux_debugging_ssl.md:11: *   `SSLClientSocketImpl` can log its state
transitions and function calls
[I forget what order things were landing in what, but you might want to tweak
this if the SSLClientSocketImpl CL ends up second.]

[svaldez, 2016-04-26 15:09:45]

The CQ bit was checked by svaldez@chromium.org

[commit-bot: I haz the power, 2016-04-26 15:09:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921743002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921743002/20001

[commit-bot: I haz the power, 2016-04-26 16:54:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-26 16:55:56]

Description was changed from

==========
Removing debugging information for NSS and Valgrind Suppressions

Since we no longer use NSS for SSL/Crypto, the debugging information
for it is outdated and we no longer need to include the Valgrind
Suppressions.

BUG=604728
==========

to

==========
Removing debugging information for NSS and Valgrind Suppressions

Since we no longer use NSS for SSL/Crypto, the debugging information
for it is outdated and we no longer need to include the Valgrind
Suppressions.

BUG=604728

Committed: https://crrev.com/72b40a33f27d3fb1757508c53cc7ffafa9e0d1bb
Cr-Commit-Position: refs/heads/master@{#389808}
==========

[commit-bot: I haz the power, 2016-04-26 16:55:57]

Patchset 2 (id:??) landed as
https://crrev.com/72b40a33f27d3fb1757508c53cc7ffafa9e0d1bb
Cr-Commit-Position: refs/heads/master@{#389808}