Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1921733002:
Support WeakMember<const T>. (Closed)
|
Created:
4 years, 8 months ago by sof Modified:
4 years, 7 months ago Reviewers:
haraken CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), haraken, blink-reviews, kinuko+watch, kouhei+heap_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSupport WeakMember<const T>.
It is entirely valid to have weak references to const objects, but
this failed to compile tracing calls over such members.
R=haraken
BUG=
Committed: https://crrev.com/b55865523897cc61a5a90efed5b28a533ba8cf66
Cr-Commit-Position: refs/heads/master@{#389553}
Patch Set 1 #
Messages
Total messages: 20 (11 generated)
haraken@chromium.org changed reviewers: + haraken@chromium.org
LGTM
Description was changed from ========== Support WeakMember<const T>. It is entirely valid to have weak references to const objects, but this failed to compile tracing calls over such members. R= BUG= ========== to ========== Support WeakMember<const T>. It is entirely valid to have weak references to const objects, but this failed to compile tracing calls over such members. R=haraken BUG= ==========
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921733002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921733002/1
The CQ bit was unchecked by sigbjornf@opera.com
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921733002/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to commit the patch.
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921733002/1
Message was sent while issue was closed.
Description was changed from ========== Support WeakMember<const T>. It is entirely valid to have weak references to const objects, but this failed to compile tracing calls over such members. R=haraken BUG= ========== to ========== Support WeakMember<const T>. It is entirely valid to have weak references to const objects, but this failed to compile tracing calls over such members. R=haraken BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Support WeakMember<const T>. It is entirely valid to have weak references to const objects, but this failed to compile tracing calls over such members. R=haraken BUG= ========== to ========== Support WeakMember<const T>. It is entirely valid to have weak references to const objects, but this failed to compile tracing calls over such members. R=haraken BUG= Committed: https://crrev.com/b55865523897cc61a5a90efed5b28a533ba8cf66 Cr-Commit-Position: refs/heads/master@{#389553} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b55865523897cc61a5a90efed5b28a533ba8cf66 Cr-Commit-Position: refs/heads/master@{#389553} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
