Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1921673004: S390: [interpreter] Heal closures when bytecode array is gone. (Closed)

Created:
4 years, 8 months ago by john.yan
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: [interpreter] Heal closures when bytecode array is gone. Port 5c8609de9d597000fdb92dffe954d7ed994488b2 Original commit message: This ensures the InterpreterEntryTrampoline heals code entry fields inside closures when being called without a valid bytecode array. This is preparatory work to allow removal of bytecode when switching some functions to other types of code. R=mstarzinger@chromium.org, joransiu@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4280 LOG=N Committed: https://crrev.com/612368b86e3f7012a63049ee47411b2e060adcc7 Cr-Commit-Position: refs/heads/master@{#35776}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M src/s390/builtins-s390.cc View 3 chunks +20 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
john.yan
PTAL
4 years, 8 months ago (2016-04-25 18:16:13 UTC) #1
JoranSiu
On 2016/04/25 18:16:13, john.yan wrote: > PTAL lgtm
4 years, 8 months ago (2016-04-25 19:43:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921673004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921673004/1
4 years, 8 months ago (2016-04-25 19:47:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 20:06:18 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 20:07:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/612368b86e3f7012a63049ee47411b2e060adcc7
Cr-Commit-Position: refs/heads/master@{#35776}

Powered by Google App Engine
This is Rietveld 408576698