Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1921623002: Remove unnecessary ExceptionCode.h inclusion (Closed)

Created:
4 years, 8 months ago by Srirama
Modified:
4 years, 8 months ago
Reviewers:
haraken
CC:
chromium-reviews, philipj_slow, tommyw+watchlist_chromium.org, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, blink-reviews-html_chromium.org, chasej+watch_chromium.org, eric.carlson_apple.com, dglazkov+blink, scheib+watch_chromium.org, blink-reviews-bindings_chromium.org, nhiroki, blink-reviews, ortuno+watch_chromium.org, tzik, kinuko+fileapi, mcasas+watch+mediastream_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary ExceptionCode.h inclusion Though ExceptionCode.h is included, it's not used in some of the places Committed: https://crrev.com/5c27a8d680baaa0fabcf39f82ee6b8c102953243 Cr-Commit-Position: refs/heads/master@{#389717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLProgressElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/origin_trials/OriginTrialContextTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeySystemAccess.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DirectoryEntrySync.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DirectoryReaderSync.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/FileWriter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasource/TrackDefault.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaDevicesRequest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCDataChannelTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/quota/DeprecatedStorageQuotaCallbacksImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/quota/StorageQuotaCallbacksImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DOMWindowWebDatabase.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Srirama
PTAL. This is the last one.
4 years, 8 months ago (2016-04-26 04:37:45 UTC) #3
haraken
LGTM
4 years, 8 months ago (2016-04-26 07:00:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921623002/1
4 years, 8 months ago (2016-04-26 07:02:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 07:11:40 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 07:13:46 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5c27a8d680baaa0fabcf39f82ee6b8c102953243
Cr-Commit-Position: refs/heads/master@{#389717}

Powered by Google App Engine
This is Rietveld 408576698