Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1921573002: Suppress logspam arising from trying to register/load v8 blobs. (Closed)

Created:
4 years, 8 months ago by Tobias Sargeant
Modified:
4 years, 8 months ago
CC:
android-webview-reviews_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppress logspam arising from trying to register/load v8 blobs. Because we don't know which blobs we will end up using, because we can't predict from the browser process what ABI the renderer process will end up executing with, we can't log an error immediately. Instead we should pass through the returned invalid file descriptor and let the renderer process fail if it doesn't have access to the blobs it needs. BUG=594563 Committed: https://crrev.com/02b5769f94789389b278bb7a6157ce6fd94b5dcd Cr-Commit-Position: refs/heads/master@{#389799}

Patch Set 1 #

Patch Set 2 : Just drop the log message on the floor if it is empty or equal to the filename #

Patch Set 3 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M base/android/java/src/org/chromium/base/ApkAssets.java View 1 2 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Tobias Sargeant
4 years, 8 months ago (2016-04-25 10:27:32 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-25 11:00:53 UTC) #3
Torne
LGTM
4 years, 8 months ago (2016-04-26 15:06:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921573002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921573002/40001
4 years, 8 months ago (2016-04-26 15:15:44 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-26 16:15:02 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 16:16:17 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/02b5769f94789389b278bb7a6157ce6fd94b5dcd
Cr-Commit-Position: refs/heads/master@{#389799}

Powered by Google App Engine
This is Rietveld 408576698