Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: components/offline_pages/offline_page_model.h

Issue 1921563005: [Offline Pages] Remove obsolete synchronous API methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add todo Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model.h
diff --git a/components/offline_pages/offline_page_model.h b/components/offline_pages/offline_page_model.h
index cad35565f61f8283da1eb0f10437f9aa738c71a4..357979161245a0d41306bf8c3e5889cf70921a66 100644
--- a/components/offline_pages/offline_page_model.h
+++ b/components/offline_pages/offline_page_model.h
@@ -174,14 +174,6 @@ class OfflinePageModel : public KeyedService, public base::SupportsUserData {
const base::Callback<bool(const GURL&)>& predicate,
const DeletePageCallback& callback);
- // Returns true if there are offline pages in the given |name_space|. This
- // method is sync, so the result can be wrong depending on implementation
- // details of the model.
- //
- // Currently, this will return |false| if the model is not loaded, even if
- // there are pages on disk.
- bool MaybeHasPages(const std::string& name_space) const;
-
// Returns true via callback if there are offline pages in the given
// |name_space|.
void HasPages(const std::string& name_space,
@@ -192,6 +184,7 @@ class OfflinePageModel : public KeyedService, public base::SupportsUserData {
// Gets pages that should be removed to clean up storage. Requires that the
// model is loaded.
+ // TODO(fgorski): This needs an update as part of expiration policy work.
const std::vector<OfflinePageItem> GetPagesToCleanUp() const;
// Gets all offline ids where the offline page has the matching client id
« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_bridge.cc ('k') | components/offline_pages/offline_page_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698