components/offline_pages/offline_page_model.h - Issue 1921563005: [Offline Pages] Remove obsolete synchronous API methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/offline_page_model.h

Issue 1921563005: [Offline Pages] Remove obsolete synchronous API methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_bridge.cc ('k') | components/offline_pages/offline_page_model.cc » ('j') | components/offline_pages/offline_page_model.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/offline_page_model.h

diff --git a/components/offline_pages/offline_page_model.h b/components/offline_pages/offline_page_model.h

index cad35565f61f8283da1eb0f10437f9aa738c71a4..d95da58fbd9390a6bd4fce9826e466f628854480 100644

--- a/components/offline_pages/offline_page_model.h

+++ b/components/offline_pages/offline_page_model.h

@@ -174,14 +174,6 @@ class OfflinePageModel : public KeyedService, public base::SupportsUserData {

const base::Callback<bool(const GURL&)>& predicate,

const DeletePageCallback& callback);

- // Returns true if there are offline pages in the given |name_space|. This

- // method is sync, so the result can be wrong depending on implementation

- // details of the model.

- //

- // Currently, this will return |false| if the model is not loaded, even if

- // there are pages on disk.

- bool MaybeHasPages(const std::string& name_space) const;

// Returns true via callback if there are offline pages in the given

// |name_space|.

void HasPages(const std::string& name_space,