Add CMake path to gradle

Add CMake path to gradle

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1921553009

Committed: https://skia.googlesource.com/skia/+/2275017e45305b5bca8d82803b9ced9d5da3fd72

[liyuqian, 2016-04-29 19:20:09]

Description was changed from

==========
Add CMake path to gradle

BUG=skia:
==========

to

==========
Add CMake path to gradle

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[liyuqian, 2016-04-29 19:21:10]

Description was changed from

==========
Add CMake path to gradle

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add CMake path to gradle

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[liyuqian, 2016-04-29 19:21:10]

liyuqian@google.com changed reviewers:
+ djsollen@google.com

[djsollen, 2016-04-29 19:30:07]

https://codereview.chromium.org/1921553009/diff/1/platform_tools/android/apps...
File platform_tools/android/apps/build.gradle (right):

https://codereview.chromium.org/1921553009/diff/1/platform_tools/android/apps...
platform_tools/android/apps/build.gradle:77: if (requireCMake &&
!path.contains("cmake")) {
check that getSDKPath() + "/cmake/bin" exists because we need that particular
version of cmake since it has android specific stuff.

https://codereview.chromium.org/1921553009/diff/1/platform_tools/android/apps...
platform_tools/android/apps/build.gradle:78: path += ":" + getSDKPath() +
"/cmake/bin"
prepend this to the path since we need to pick the copy in the SDK over any
other one on their system which won't have the android specific stuff that we
need.

https://codereview.chromium.org/1921553009/diff/1/platform_tools/android/apps...
platform_tools/android/apps/build.gradle:79: // No need to check and throw
exception here because getSDKPath() already did that.
we should throw an exception if they don't have the android SDK version of cmake
so they know to install it.

[liyuqian, 2016-04-29 19:46:31]

Sorry that I forgot the check. Now I've added it.

[djsollen, 2016-04-30 01:49:01]

https://codereview.chromium.org/1921553009/diff/40001/platform_tools/android/...
File platform_tools/android/apps/build.gradle (right):

https://codereview.chromium.org/1921553009/diff/40001/platform_tools/android/...
platform_tools/android/apps/build.gradle:77: if (requireCMake &&
!path.contains("cmake")) {
almost.  This may still allow someone who just has the standard cmake install
(not the android one) to appear to be successful.  I think we want to make the
outer if statement be just...

if (requireCMake) {

[liyuqian, 2016-05-02 11:49:02]

Now it's guaranteed that the Android CMake is added.

[djsollen, 2016-05-02 12:22:18]

lgtm

[djsollen, 2016-05-02 12:22:33]

The CQ bit was checked by djsollen@google.com

[commit-bot: I haz the power, 2016-05-02 12:22:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921553009/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921553009/80001

[commit-bot: I haz the power, 2016-05-02 12:33:23]

Description was changed from

==========
Add CMake path to gradle

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add CMake path to gradle

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/2275017e45305b5bca8d82803b9ced9d5da3fd72
==========

[commit-bot: I haz the power, 2016-05-02 12:33:24]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/2275017e45305b5bca8d82803b9ced9d5da3fd72