third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 1921553008: Fix scroll origin, overflow rects, and coordinate flipping for flexbox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 1921553008: Fix scroll origin, overflow rects, and coordinate flipping for flexbox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Split flexbox refactor into separate CL Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/css3/flexbox/flexbox-overflow-auto-expected.html ('k') | third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h » ('j') | third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index ffbe2f18715c4a113784f356381cfaaaeb5d4743..b95e3ca9cb4cc3008aff63786b298184f3d6995c 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -955,7 +955,11 @@ IntSize LayoutBox::scrolledContentOffset() const

ASSERT(hasOverflowClip());

ASSERT(hasLayer());

// FIXME: Return DoubleSize here. crbug.com/414283.

- return flooredIntSize(getScrollableArea()->scrollOffset());

+ PaintLayerScrollableArea* scrollableArea = getScrollableArea();

+ IntSize result = flooredIntSize(scrollableArea->scrollOffset()) + scrollableArea->originAdjustmentForScrollbars();

+ if (isHorizontalWritingMode() && shouldPlaceBlockDirectionScrollbarOnLogicalLeft())

leviw_travelin_and_unemployed 2016/04/28 22:12:12 Probably deserves a comment.

+ result.expand(-verticalScrollbarWidth(), 0);

+ return result;

}

bool LayoutBox::mapScrollingContentsRectToBoxSpace(LayoutRect& rect, ApplyOverflowClipFlag applyOverflowClip, VisualRectFlags visualRectFlags) const