Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.h

Issue 1921553008: Fix scroll origin, overflow rects, and coordinate flipping for flexbox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Add docs to Source/core/layout/README.md Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBox.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.h b/third_party/WebKit/Source/core/layout/LayoutBox.h
index bff6c3b63427dd7bc59b3cfa17e2d73c9ac43e5c..c08f774a7f639b7ef02a5ab18bbb862058541550 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.h
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.h
@@ -380,6 +380,13 @@ public:
LayoutRect selfVisualOverflowRect() const { return m_overflow ? m_overflow->selfVisualOverflowRect() : borderBoxRect(); }
LayoutRect contentsVisualOverflowRect() const { return m_overflow ? m_overflow->contentsVisualOverflowRect() : LayoutRect(); }
+ // These methods don't mean the box *actually* has top/left overflow. They mean that
cbiesinger 2016/05/11 19:44:00 maybe rename to canOverflowTo{Top,Left}?
+ // *if* the box overflows, it will overflow to the top/left rather than the bottom/right.
+ // This happens when child content is laid out right-to-left (e.g. direction:rtl) or
+ // or bottom-to-top (e.g. direction:rtl writing-mode:vertical-rl).
+ virtual bool hasTopOverflow() const;
leviw_travelin_and_unemployed 2016/05/10 17:52:42 The name still strikes me as confusing (seems like
+ virtual bool hasLeftOverflow() const;
+
void addLayoutOverflow(const LayoutRect&);
void addSelfVisualOverflow(const LayoutRect&);
void addContentsVisualOverflow(const LayoutRect&);
@@ -871,6 +878,8 @@ public:
virtual bool needsPreferredWidthsRecalculation() const;
+ // See README.md for an explanation of scroll origin.
+ virtual IntSize originAdjustmentForScrollbars() const;
IntSize scrolledContentOffset() const;
// Maps a rect in scrolling contents space to box space and apply overflow clip if needed.

Powered by Google App Engine
This is Rietveld 408576698