Fix scroll origin, overflow rects, and coordinate flipping for flexbox.

third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  *
  * Portions are Copyright (C) 1998 Netscape Communications Corporation.
  *
  * Other contributors:
  *   Robert O'Callahan <roc+@cs.cmu.edu>
  *   David Baron <dbaron@fas.harvard.edu>
  *   Christian Biesinger <cbiesinger@gmail.com>
  *   Randall Jesup <rjesup@wgate.com>
@@ skipping 569 matching lines @@
 int PaintLayerScrollableArea::pixelSnappedScrollWidth() const
 {
     return snapSizeToPixel(scrollWidth(), box().clientLeft() + box().location().x());
 }
 
 int PaintLayerScrollableArea::pixelSnappedScrollHeight() const
 {
     return snapSizeToPixel(scrollHeight(), box().clientTop() + box().location().y());
 }
 
+IntSize PaintLayerScrollableArea::originAdjustmentForScrollbars() const

[leviw_travelin_and_unemployed, 2016/04/28 22:12:12]

This deserves a big description about why it exists and what the cases are. I
know that's a bit of a pain to write up, but I don't want the arcane knowledge
you acquired to just be cargo-culted forever :)

+{
+    IntSize size;
+    int verticalScrollbarWidth = box().verticalScrollbarWidth();
+    int horizontalScrollbarHeight = box().horizontalScrollbarHeight();
+
+    if (box().hasFlippedBlocksWritingMode()) {
+        if (box().isFlexibleBox()) {

[leviw_travelin_and_unemployed, 2016/04/28 22:12:12]

It seems like it may be easier/clearer to handle the FlexBox case first and
separately (maybe even in another function that describes why it's different),
then the  non-flex case should seem easier.

The two intertwined like this makes it harder to understand the different cases.

+            EFlexDirection flexDirection = box().style()->flexDirection();
+            if (flexDirection != FlowColumnReverse)
+                size.expand(verticalScrollbarWidth, 0);
+            if (flexDirection == FlowRowReverse)
+                size.expand(0, horizontalScrollbarHeight);
+        } else {
+            size.expand(verticalScrollbarWidth, 0);
+        }
+    } else if (box().isHorizontalWritingMode()) {
+        if (box().isFlexibleBox()) {
+            EFlexDirection flexDirection = box().style()->flexDirection();
+            if (flexDirection == FlowRowReverse)
+                size.expand(verticalScrollbarWidth, 0);
+            else if (flexDirection == FlowColumnReverse)
+                size.expand(0, horizontalScrollbarHeight);
+        } else if (box().shouldPlaceBlockDirectionScrollbarOnLogicalLeft()) {
+            size.expand(verticalScrollbarWidth, 0);
+        }
+    } else if (box().isFlexibleBox()) {
+        EFlexDirection flexDirection = box().style()->flexDirection();
+        if (flexDirection == FlowColumnReverse)
+            size.expand(verticalScrollbarWidth, 0);
+        else if (flexDirection == FlowRowReverse)
+            size.expand(0, horizontalScrollbarHeight);
+    }
+    return size;
+}
+
 void PaintLayerScrollableArea::computeScrollDimensions()
 {
     m_overflowRect = box().layoutOverflowRect();
     box().flipForWritingMode(m_overflowRect);
 
-    int scrollableLeftOverflow = m_overflowRect.x() - box().borderLeft() - (box().shouldPlaceBlockDirectionScrollbarOnLogicalLeft() ? box().verticalScrollbarWidth() : 0);
-    int scrollableTopOverflow = m_overflowRect.y() - box().borderTop();
-    setScrollOrigin(IntPoint(-scrollableLeftOverflow, -scrollableTopOverflow));
+    LayoutPoint scrollableOverflow = m_overflowRect.location() - LayoutSize(box().borderLeft(), box().borderTop());
+    setScrollOrigin(flooredIntPoint(-scrollableOverflow) + originAdjustmentForScrollbars());
 }
 
 void PaintLayerScrollableArea::scrollToPosition(const DoublePoint& scrollPosition, ScrollOffsetClamping clamp, ScrollBehavior scrollBehavior, ScrollType scrollType)
 {
     cancelProgrammaticScrollAnimation();
 
     DoublePoint newScrollPosition = clamp == ScrollOffsetClamped ? clampScrollPosition(scrollPosition) : scrollPosition;
     if (newScrollPosition != scrollPositionDouble())
         ScrollableArea::setScrollPosition(newScrollPosition, scrollType, scrollBehavior);
 }
@@ skipping 1001 matching lines @@
 }
 
 DEFINE_TRACE(PaintLayerScrollableArea::ScrollbarManager)
 {
     visitor->trace(m_scrollableArea);
     visitor->trace(m_hBar);
     visitor->trace(m_vBar);
 }
 
 } // namespace blink