Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 1921553006: [ios] Do not allow loading chrome:// URLs from regular http/https pages. (Closed)

Created:
4 years, 8 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 8 months ago
Reviewers:
Andy Caruso
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

[ios] Do not allow loading chrome:// URLs from regular http/https pages. Merged trunk CL: https://codereview.chromium.org/1900783003/ BUG=604086 NOTRY=true NOPRESUBMIT=true TEST=WebUI still works, but can not be loaded from http/https pages

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M ios/web/web_state/ui/crw_wk_web_view_web_controller.mm View 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Eugene But (OOO till 7-30)
4 years, 8 months ago (2016-04-26 23:02:13 UTC) #3
Andy Caruso
On 2016/04/26 23:02:13, Eugene But wrote: lgtm
4 years, 8 months ago (2016-04-27 01:32:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921553006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921553006/1
4 years, 8 months ago (2016-04-27 02:26:33 UTC) #6
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 8 months ago (2016-04-27 02:26:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921553006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921553006/1
4 years, 8 months ago (2016-04-27 04:13:56 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-27 04:15:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698