Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1921553005: Revert "Delay Firefox browser startup in test scripts, to flatten load." (Closed)

Created:
4 years, 7 months ago by Bill Hesse
Modified:
4 years, 7 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org, ahe, Johnni Winther
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Delay Firefox browser startup in test scripts, to flatten load." This reverts commit 40b69fd615afad6beb7e625757bc176964325f90. BUG=https://github.com/dart-lang/sdk/issues/26060 R=kevmoo@google.com Committed: https://github.com/dart-lang/sdk/commit/7c9219a48eee77983f7aac9448a8e8459cad1200

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M tools/testing/dart/browser_controller.dart View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
This is causing the test infrastructure to break.
4 years, 7 months ago (2016-04-26 19:20:14 UTC) #2
kevmoo
lgtm
4 years, 7 months ago (2016-04-26 19:28:13 UTC) #3
Bill Hesse
4 years, 7 months ago (2016-04-26 19:29:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7c9219a48eee77983f7aac9448a8e8459cad1200 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698