Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1111)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

Issue 1921553004: Add favicon and publisher name to snippet cards (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
index fafb73b72dd8e21139fa956d03697bc89fb0d9f0..1676bf209897db01f0a9e54ea33b05599ea0d86d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
@@ -106,16 +106,16 @@ public class SnippetsBridge {
}
@CalledByNative
- private void onSnippetsAvailable(String[] titles, String[] urls, String[] thumbnailUrls,
- String[] previewText, long[] timestamps) {
+ private void onSnippetsAvailable(String[] titles, String[] urls, String[] ampUrls,
+ String[] thumbnailUrls, String[] previewText, long[] timestamps, String[] publishers) {
// Don't notify observer if we've already been destroyed.
if (mNativeSnippetsBridge == 0) return;
assert mObserver != null;
List<SnippetArticle> newSnippets = new ArrayList<>(titles.length);
for (int i = 0; i < titles.length; i++) {
- newSnippets.add(new SnippetArticle(
- titles[i], "", previewText[i], urls[i], thumbnailUrls[i], timestamps[i], i));
+ newSnippets.add(new SnippetArticle(titles[i], publishers[i], previewText[i], urls[i],
+ ampUrls[i], thumbnailUrls[i], timestamps[i], i));
}
mObserver.onSnippetsReceived(newSnippets);

Powered by Google App Engine
This is Rietveld 408576698