components/ntp_snippets/ntp_snippets_service.cc - Issue 1921553004: Add favicon and publisher name to snippet cards

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/ntp_snippets_service.cc

Issue 1921553004: Add favicon and publisher name to snippet cards (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review comments. Will address test issues in another update. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ntp_snippets/ntp_snippets_service.cc

diff --git a/components/ntp_snippets/ntp_snippets_service.cc b/components/ntp_snippets/ntp_snippets_service.cc

index af047ac3af7da517dda41c378aa711cfd3cecd9c..749dc16e5e41ca99299b89f6fc8d8d2d25c82677 100644

--- a/components/ntp_snippets/ntp_snippets_service.cc

+++ b/components/ntp_snippets/ntp_snippets_service.cc

@@ -145,7 +145,12 @@ bool AddSnippetsFromListValue(const base::ListValue& list,

if (!snippet)

return false;

- snippets->push_back(std::move(snippet));

+// If we're running a release build, only add snippets that have all the

+// data we need to display it properly

+#if !DCHECK_IS_ON()

+ if (snippet->is_complete())

+#endif

+ snippets->push_back(std::move(snippet));

}

return true;

}