Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1054)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/android/java/res/layout/new_tab_page_snippets_card.xml

Issue 1921553004: Add favicon and publisher name to snippet cards (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review comments. Will address test issues in another update. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java » ('j') | chrome/browser/android/ntp/ntp_snippets_bridge.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/layout/new_tab_page_snippets_card.xml
diff --git a/chrome/android/java/res/layout/new_tab_page_snippets_card.xml b/chrome/android/java/res/layout/new_tab_page_snippets_card.xml
index 703bfec4ec77b22c4c1ff6237020ad17d0eb6731..4e92dd5204aae3919b8f5a83cf63fef5726ce669 100644
--- a/chrome/android/java/res/layout/new_tab_page_snippets_card.xml
+++ b/chrome/android/java/res/layout/new_tab_page_snippets_card.xml
@@ -39,12 +39,13 @@
android:id="@+id/article_publisher"
android:layout_width="match_parent"
android:layout_height="wrap_content"
- android:layout_below="@+id/article_snippet"
- android:layout_toStartOf="@+id/article_thumbnail"
android:layout_marginTop="16dp"
+ android:layout_alignParentStart="true"
+ android:layout_below="@+id/article_snippet"
+ android:drawablePadding="8dp"
android:maxLines="1"
android:ellipsize="end"
- android:textSize="14sp"
+ android:textSize="12sp"
android:textColor="@color/snippets_publisher_name_color" />
<ImageView
@@ -57,5 +58,5 @@
android:layout_marginStart="16dp"
android:scaleType="centerCrop"
android:contentDescription="@null"
- android:src="@null"/>
+ android:src="@null" />
</RelativeLayout>
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java » ('j') | chrome/browser/android/ntp/ntp_snippets_bridge.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698