Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2559)

Unified Diff: chrome/browser/android/ntp/ntp_snippets_bridge.cc

Issue 1921553004: Add favicon and publisher name to snippet cards (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/ntp/ntp_snippets_bridge.cc
diff --git a/chrome/browser/android/ntp/ntp_snippets_bridge.cc b/chrome/browser/android/ntp/ntp_snippets_bridge.cc
index 569b3c7ad2a00554b89b7d5e38618b69b345efed..b5ec421f1466be6986c60cd32303ee9e7386880a 100644
--- a/chrome/browser/android/ntp/ntp_snippets_bridge.cc
+++ b/chrome/browser/android/ntp/ntp_snippets_bridge.cc
@@ -115,12 +115,14 @@ void NTPSnippetsBridge::NTPSnippetsServiceLoaded() {
std::vector<std::string> thumbnail_urls;
std::vector<std::string> snippets;
std::vector<int64_t> timestamps;
+ std::vector<std::string> publishers;
for (const ntp_snippets::NTPSnippet& snippet : *ntp_snippets_service_) {
titles.push_back(snippet.title());
urls.push_back(snippet.url().spec());
thumbnail_urls.push_back(snippet.salient_image_url().spec());
snippets.push_back(snippet.snippet());
timestamps.push_back(snippet.publish_date().ToJavaTime());
+ publishers.push_back(snippet.site_title());
}
JNIEnv* env = base::android::AttachCurrentThread();
@@ -129,7 +131,8 @@ void NTPSnippetsBridge::NTPSnippetsServiceLoaded() {
ToJavaArrayOfStrings(env, urls).obj(),
ToJavaArrayOfStrings(env, thumbnail_urls).obj(),
ToJavaArrayOfStrings(env, snippets).obj(),
- ToJavaLongArray(env, timestamps).obj());
+ ToJavaLongArray(env, timestamps).obj(),
+ ToJavaArrayOfStrings(env, publishers).obj());
}
void NTPSnippetsBridge::NTPSnippetsServiceShutdown() {

Powered by Google App Engine
This is Rietveld 408576698