chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java - Issue 1921553004: Add favicon and publisher name to snippet cards

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java

Issue 1921553004: Add favicon and publisher name to snippet cards (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/layout/new_tab_page_snippets_card.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java

index 9e68b0a14ba4484fe89a94eed388f60e55a990b6..dfbfd322f5726948168bc398f063ce6bb253c900 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java

@@ -61,14 +61,14 @@ public class SnippetArticle implements NewTabPageListItem {

}

/**

- * Returns this article's tumbnail as a {@link Bitmap}. Can return {@code null} as it is

+ * Returns this article's thumbnail as a {@link Bitmap}. Can return {@code null} as it is

* initially unset.

public Bitmap getThumbnailBitmap() {

return mThumbnailBitmap;

}

- /** Sets the tumbnail bitmap for this article. */

+ /** Sets the thumbnail bitmap for this article. */

public void setThumbnailBitmap(Bitmap bitmap) {

mThumbnailBitmap = bitmap;

}