| Index: chrome/browser/permissions/permission_uma_util.cc
|
| diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc
|
| index 8d38d0451210d25d95cecac7af49fd236e0d2b1b..1f39ae59a02fd777ab62cccb7cf6450fb96dd6d3 100644
|
| --- a/chrome/browser/permissions/permission_uma_util.cc
|
| +++ b/chrome/browser/permissions/permission_uma_util.cc
|
| @@ -36,8 +36,6 @@ using content::PermissionType;
|
|
|
| namespace {
|
|
|
| -// Deprecated. This method is used for the single-dimensional RAPPOR metrics
|
| -// that are being replaced by the multi-dimensional ones.
|
| const std::string GetRapporMetric(PermissionType permission,
|
| PermissionAction action) {
|
| std::string action_str;
|
| @@ -144,32 +142,18 @@ void RecordPermissionAction(PermissionType permission,
|
| << " not accounted for";
|
| }
|
|
|
| - // There are two sets of semi-redundant RAPPOR metrics being reported:
|
| - // The soon-to-be-deprecated single dimensional ones, and the new
|
| - // multi-dimensional ones.
|
| - rappor::RapporService* rappor_service = g_browser_process->rappor_service();
|
| const std::string rappor_metric = GetRapporMetric(permission, action);
|
| - if (!rappor_metric.empty())
|
| - rappor::SampleDomainAndRegistryFromGURL(
|
| - rappor_service, rappor_metric, requesting_origin);
|
| + if (!rappor_metric.empty()) {
|
| + // TODO(dominickn): remove this deprecated metric - crbug.com/605836.
|
| + rappor::SampleDomainAndRegistryFromGURL(g_browser_process->rappor_service(),
|
| + rappor_metric, requesting_origin);
|
|
|
| - // Add multi-dimensional RAPPOR reporting for safe-browsing users.
|
| - std::string permission_str =
|
| - PermissionUtil::GetPermissionString(permission);
|
| - if (!rappor_service || permission_str.empty())
|
| - return;
|
| -
|
| - std::unique_ptr<rappor::Sample> sample =
|
| - rappor_service->CreateSample(rappor::SAFEBROWSING_RAPPOR_TYPE);
|
| - sample->SetStringField("Scheme", requesting_origin.scheme());
|
| - sample->SetStringField("Host", requesting_origin.host());
|
| - sample->SetStringField("Port", requesting_origin.port());
|
| - sample->SetStringField("Domain",
|
| - rappor::GetDomainAndRegistrySampleFromGURL(requesting_origin));
|
| - sample->SetFlagsField("Actions", static_cast<uint64_t>(1) << action,
|
| - PermissionAction::PERMISSION_ACTION_NUM);
|
| - rappor_service->RecordSampleObj("Permissions.Action." + permission_str,
|
| - std::move(sample));
|
| + std::string new_rappor_metric =
|
| + base::StringPrintf("%s2", rappor_metric.c_str());
|
| + rappor::SampleDomainAndRegistryFromGURL(g_browser_process->rappor_service(),
|
| + new_rappor_metric,
|
| + requesting_origin);
|
| + }
|
| }
|
|
|
| void RecordPermissionRequest(PermissionType permission,
|
| @@ -178,15 +162,25 @@ void RecordPermissionRequest(PermissionType permission,
|
| Profile* profile) {
|
| bool secure_origin = content::IsOriginSecure(requesting_origin);
|
| if (permission == PermissionType::GEOLOCATION) {
|
| + // TODO(dominickn): remove this deprecated metric - crbug.com/605836.
|
| rappor::SampleDomainAndRegistryFromGURL(
|
| g_browser_process->rappor_service(),
|
| "ContentSettings.PermissionRequested.Geolocation.Url",
|
| requesting_origin);
|
| + rappor::SampleDomainAndRegistryFromGURL(
|
| + g_browser_process->rappor_service(),
|
| + "ContentSettings.PermissionRequested.Geolocation.Url2",
|
| + requesting_origin);
|
| } else if (permission == PermissionType::NOTIFICATIONS) {
|
| + // TODO(dominickn): remove this deprecated metric - crbug.com/605836.
|
| rappor::SampleDomainAndRegistryFromGURL(
|
| g_browser_process->rappor_service(),
|
| "ContentSettings.PermissionRequested.Notifications.Url",
|
| requesting_origin);
|
| + rappor::SampleDomainAndRegistryFromGURL(
|
| + g_browser_process->rappor_service(),
|
| + "ContentSettings.PermissionRequested.Notifications.Url2",
|
| + requesting_origin);
|
| }
|
| UMA_HISTOGRAM_ENUMERATION(
|
| "ContentSettings.PermissionRequested",
|
|
|