Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Issue 1921533002: Revert of Check for semaphore alignment on posix platforms. (Closed)

Created:
4 years, 8 months ago by Michael Hablich
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Check for semaphore alignment on posix platforms. (patchset #1 id:1 of https://codereview.chromium.org/1912923003/ ) Reason for revert: blocks rolling. See https://bugs.chromium.org/p/chromium/issues/detail?id=605349 for more information. This CL only triggers the problem earlier but is not the culprit. The real bug is under investigation by the GC team. Original issue's description: > Check for semaphore alignment on posix platforms. > > BUG=chromium:605349 > LOG=NO > > Committed: https://crrev.com/8d24472acfaf7e67ca20106cb1f405fc0590c849 > Cr-Commit-Position: refs/heads/master@{#35717} TBR=mlippautz@chromium.org,ulan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:605349 LOG=N Committed: https://crrev.com/80c73e2cde6020f8a3879408bee72828e887e3d5 Cr-Commit-Position: refs/heads/master@{#35755}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M src/base/platform/semaphore.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Michael Hablich
Created Revert of Check for semaphore alignment on posix platforms.
4 years, 8 months ago (2016-04-25 08:59:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921533002/1
4 years, 8 months ago (2016-04-25 08:59:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921533002/1
4 years, 8 months ago (2016-04-25 09:01:57 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/14084)
4 years, 8 months ago (2016-04-25 09:04:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921533002/1
4 years, 8 months ago (2016-04-25 09:08:16 UTC) #8
Michael Achenbach
lgtm
4 years, 8 months ago (2016-04-25 09:18:07 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 09:24:56 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 09:25:21 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/80c73e2cde6020f8a3879408bee72828e887e3d5
Cr-Commit-Position: refs/heads/master@{#35755}

Powered by Google App Engine
This is Rietveld 408576698