third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp - Issue 1921503008: Blink CompositorWorker: Use CompositorElementId and CompositorIdToElementMap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

Issue 1921503008: Blink CompositorWorker: Use CompositorElementId and CompositorIdToElementMap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@elementid

Patch Set: Vend ids via local blink nextCompositorElementId. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/CompositorIdToElementMap.cpp ('K') | « third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp b/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

index 02fe615fc884494b012868f754ceb371cac02a40..ecc21935aeb22a08648b8836afadf4c2506fd479 100644

--- a/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

@@ -27,6 +27,7 @@

#include "core/animation/AnimationTimeline.h"

#include "core/animation/DocumentAnimations.h"

+#include "core/dom/CompositorIdToElementMap.h"

#include "core/dom/DOMNodeIds.h"

#include "core/dom/Fullscreen.h"

#include "core/editing/FrameSelection.h"

@@ -406,7 +407,8 @@ void PaintLayerCompositor::updateIfNeeded()

CompositorElementId elementId = 0;

uint32_t mutableProperties = CompositorMutableProperty::kNone;

if (scrollingElement->hasCompositorProxy()) {

- elementId = DOMNodeIds::idForNode(scrollingElement);

+ elementId = scrollingElement->assignCompositorElementId();

+ CompositorIdToElementMap::registerElement(*scrollingElement);

mutableProperties = (CompositorMutableProperty::kScrollLeft | CompositorMutableProperty::kScrollTop) & scrollingElement->compositorMutableProperties();

}

m_scrollLayer->setElementId(elementId);