third_party/WebKit/Source/core/animation/ElementAnimations.cpp - Issue 1921503008: Blink CompositorWorker: Use CompositorElementId and CompositorIdToElementMap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/ElementAnimations.cpp

Issue 1921503008: Blink CompositorWorker: Use CompositorElementId and CompositorIdToElementMap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@elementid

Patch Set: Vend ids via local blink nextCompositorElementId. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/ElementAnimations.h ('k') | third_party/WebKit/Source/core/core.gypi » ('j') | third_party/WebKit/Source/core/dom/CompositorIdToElementMap.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/ElementAnimations.cpp

diff --git a/third_party/WebKit/Source/core/animation/ElementAnimations.cpp b/third_party/WebKit/Source/core/animation/ElementAnimations.cpp

index 1b1365022d6f33212668e0083d7f227ec7e44768..ba3fabd1c17b29c44541f59242c988b50bec03f7 100644

--- a/third_party/WebKit/Source/core/animation/ElementAnimations.cpp

+++ b/third_party/WebKit/Source/core/animation/ElementAnimations.cpp

@@ -34,8 +34,11 @@

namespace blink {

+static CompositorElementId s_nextCompositorElementId = 1;

esprehn 2016/05/10 22:46:57 You should use DOMNodeIds, why can't you allocate

loyso (OOO) 2016/05/12 05:55:39 Not every Compositor Animation subsystem has assoc

ElementAnimations::ElementAnimations()

- : m_animationStyleChange(false)

+ : m_compositorElementId(s_nextCompositorElementId++)

+ , m_animationStyleChange(false)

{

}