Issue 1921503007: simplify emitting dart.bind for native types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1921503007: simplify emitting dart.bind for native types (Closed)

Created:
4 years, 7 months ago by Jennifer Messerly

Modified:
4 years, 7 months ago

Reviewers:
vsm, Harry Terkelsen

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -17 lines)			Patch
M	lib/runtime/dart_sdk.js	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	lib/src/compiler/code_generator.dart	View	1 2	3 chunks	+15 lines, -11 lines	0 comments	Download
M	test/codegen/expect/language-all.js	View	1	Binary file		0 comments	Download
M	tool/input_sdk/private/ddc_runtime/classes.dart	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 5 (2 generated)

Jennifer Messerly

My main goal here was to fix _emitFunctionTypeParts in _emitAccess. Also tried to improve the ...

4 years, 7 months ago (2016-04-27 16:46:17 UTC) #2

Jennifer Messerly

4 years, 7 months ago (2016-04-27 16:59:40 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
5e938fd69a9d605bf2d6f37b45c838aab2ccd152 (presubmit successful).